Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[JENKINS-73158] avoid jumping layout due to tooltips #9263

Merged
merged 3 commits into from May 17, 2024
Merged

[JENKINS-73158] avoid jumping layout due to tooltips #9263

merged 3 commits into from May 17, 2024

Conversation

mawinter69
Copy link
Contributor

@mawinter69 mawinter69 commented May 11, 2024 •
edited by MarkEWaite

The fix for JENKINS-72744 made the tooltip get appended to the parent element. But this can also cause troubles in some cases. To avoid this one can now decide whether the tooltip should be appended to the body (the default) or to the parent.
Adjust all locations where a tooltip is displayed inside a widget to append it to the parent. This works well with those tooltips and avoids a jumping layout in the custom-folder-icon and potentially other places.

See JENKINS-73158.

Testing done

Manual testing that in widgets the tooltips are properly removed while with custom-folder-icon plugin, the layout stays stable.

Proposed changelog entries

  • Avoid jumping layout due to tooltips.

Proposed upgrade guidelines

N/A

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. The Jira issue, if it exists, is well-described.
    Options
  2. The changelog entries and upgrade guidelines are appropriate for the audience affected by the change (users or developers, depending on the change) and are in the imperative mood (see examples). Fill in the Proposed upgrade guidelines section only if there are breaking changes or changes that may require extra steps from users during upgrade.
    Options
  3. There is automated testing or an explanation as to why this change has no tests.
    Options
  4. New public classes, fields, and methods are annotated with @Restricted or have @since TODO Javadocs, as appropriate.
    Options
  5. New deprecations are annotated with @Deprecated(since = "TODO") or @Deprecated(forRemoval = true, since = "TODO"), if applicable.
    Options
  6. New or substantially changed JavaScript is not defined inline and does not call eval to ease future introduction of Content Security Policy (CSP) directives (see documentation).
    Options
  7. For dependency updates, there are links to external changelogs and, if possible, full differentials.
    Options
  8. For new APIs and extension points, there is a link to at least one consumer.
    Options

Desired reviewers

@mention

Before the changes are marked as ready-for-merge:

Maintainer checklist

Edit tasklist title
Beta Give feedback Tasklist Maintainer checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. There are at least two (2) approvals for the pull request and no outstanding requests for change.
    Options
  2. Conversations in the pull request are over, or it is explicit that a reviewer is not blocking the change.
    Options
  3. Changelog entries in the pull request title and/or Proposed changelog entries are accurate, human-readable, and in the imperative mood.
    Options
  4. Proper changelog labels are set so that the changelog can be generated automatically.
    Options
  5. If the change needs additional upgrade steps from users, the upgrade-guide-needed label is set and there is a Proposed upgrade guidelines section in the pull request title (see example).
    Options
  6. If it would make sense to backport the change to LTS, a Jira issue must exist, be a Bug or Improvement, and be labeled as lts-candidate to be considered (see query).
    Options

@mawinter69 mawinter69 mentioned this pull request May 11, 2024
Merged
@mawinter69
[JENKINS-73158] avoid jumping layout due to tooltips
c545ead 
The fix for JENKINS-72744 made the tooltip get appended to the parent
element. But this can also cause troubles in some cases.
To avoid this one can now decide whether the tooltip should be appended
to the body (the default) or to the parent.
Adjust all locations where a tooltip is displayed inside a widget to
append it to the parent. This works well with those tooltips and avoids
a jumping layout in the custom-folder-icon and potentially other places.
@NotMyFault NotMyFault added the rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted label May 12, 2024
@timja
Copy link
Member

timja commented May 16, 2024

/label ready-for-merge

This PR is now ready for merge, after ~24 hours, we will merge it if there's no negative feedback.

Thanks!

@comment-ops-bot comment-ops-bot bot added the ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback label May 16, 2024
MarkEWaite
MarkEWaite approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@MarkEWaite MarkEWaite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in my interactive testing both with custom folder icon and without.

@MarkEWaite MarkEWaite merged commit 5089ad5 into jenkinsci:master May 17, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MarkEWaite MarkEWaite MarkEWaite approved these changes

@NotMyFault NotMyFault NotMyFault approved these changes

@timja timja timja approved these changes

Assignees
No one assigned
Labels
ready-for-merge The PR is ready to go, and it will be merged soon if there is no negative feedback rfe For changelog: Minor enhancement. use `major-rfe` for changes to be highlighted
Projects
None yet
Milestone
No milestone
4 participants
@mawinter69 @timja @MarkEWaite @NotMyFault