Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds the possibility to mount an existing volume #702

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

kiddouk
Copy link

@kiddouk kiddouk commented Feb 5, 2020

As an example, when a k8s cluster runs on EKS (and that OIDC is configured properly), each pod that gets started on the cluster (including the jenkins-agents) gets a Projected Volume added automagically (usefull for AWS authentication, but I digress)

This patch adds the possibility of adding a volumeMount just by specifying a volume name (ie: without the template adding the volume definition).

@Vlatombe
Copy link
Member

Vlatombe commented Feb 7, 2020

I don't think it can work this way. In any case, it should be already doable using the yaml field.

@EZtheOG
Copy link

EZtheOG commented Sep 23, 2020

I don't think it can work this way. In any case, it should be already doable using the yaml field.

Is the only way to mount a volume in pod A into pod B is through the YAML field?

@Vlatombe Vlatombe added the enhancement Improvements label Nov 4, 2020
@Vlatombe
Copy link
Member

Coming back on this PR, I fail to understand what is the use case.

The current pod template model in the plugin defines volumes which get mounted in all containers. If you want something more specific, use the yaml field and you have pretty much full control on the resulting spec.

The example about EKS IAM service account doesn't seem to apply here: the admission controller injects both volume and volume mount. Why would you need to declare an additional volume mount?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Improvements
Projects
None yet
3 participants