Fix spotbugs errors

pom.xml

@@ -10,8 +10,6 @@
   <properties>
     <jenkins.version>2.426.3</jenkins.version>
     <findbugs.failOnError>true</findbugs.failOnError>
-    <!-- TODO fix violations before release and remove threshold -->
-    <spotbugs.threshold>High</spotbugs.threshold>
   </properties>
 
   <artifactId>mathworks-polyspace</artifactId>

src/main/java/com/mathworks/polyspace/jenkins/PolyspacePostBuildActions.java

@@ -55,16 +55,16 @@
  * {@link Publisher} that sends Polyspace Notification in e-mail.
  */
 public class PolyspacePostBuildActions extends Notifier implements SimpleBuildStep {
-    public Boolean sendToRecipients;    /** True if we want to send an email to a list of recipients */
-    public String recipients;           /** Whitespace-separated list of e-mail addresses that represent recipients */
-    public String fileToAttach;         /** File to attach */
-    public String mailSubject;          /** File containing the mail subject. "" if generic subject is to be applied */
-    public String mailBody;             /** File containing the mail body. "" if generic body is to be applied */
-    public Boolean sendToOwners;        /** True if we want to send an email to all owners */
-    public String queryBaseName;        /** query base name */
-    public String mailSubjectBaseName;  /** base name of the file containing the mail subject. "" if generic subject is to be applied. file for a user is mailSubjectBaseName _ user . ext */
-    public String mailBodyBaseName;     /** base name of the file containing the mail body. "" if generic body is to be applied. file for a user is mailBodyBaseName _ user . ext */
-    public String uniqueRecipients;     /** Unique recipient that receives all emails */
+    private Boolean sendToRecipients;    /** True if we want to send an email to a list of recipients */
+    private String recipients;           /** Whitespace-separated list of e-mail addresses that represent recipients */
+    private String fileToAttach;         /** File to attach */
+    private String mailSubject;          /** File containing the mail subject. "" if generic subject is to be applied */
+    private String mailBody;             /** File containing the mail body. "" if generic body is to be applied */
+    private Boolean sendToOwners;        /** True if we want to send an email to all owners */
+    private String queryBaseName;        /** query base name */
+    private String mailSubjectBaseName;  /** base name of the file containing the mail subject. "" if generic subject is to be applied. file for a user is mailSubjectBaseName _ user . ext */
+    private String mailBodyBaseName;     /** base name of the file containing the mail body. "" if generic body is to be applied. file for a user is mailBodyBaseName _ user . ext */
+    private String uniqueRecipients;     /** Unique recipient that receives all emails */
 
     @DataBoundConstructor
     public PolyspacePostBuildActions() { }

src/main/java/com/mathworks/polyspace/jenkins/utils/PolyspaceHelpersUtils.java

@@ -220,7 +220,7 @@ public static long getCountFindings(final Path report) throws IOException {
    * @param report - Path to the report
    * @param max - Thereshold for status
    * @return - Job status string: SUCCESS if num findings smaller than {@code max}, UNSTABLE otherwise
-   * @throws IOException
+   * @throws IOException Error while accessing {@code report}
    */
   public static String getReportStatus(final Path report, final long max) throws IOException
   {