Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hash escape hatch password in configuration - fix CVE-2023-50770 #287

Merged
merged 1 commit into from Apr 3, 2024

Conversation

michael-doubez
Copy link
Contributor

Store hashed password with salt in configuration to avoid recoverable format (see SECURITY-3168 / CVE-2023-50770).
The hashing uses BCrypt as indicated in SECURITY-3168.

Resolve open vulnerability as requested in #259.

Testing done

Testing of in unit test for JasC configuration. Secret migration perfomed by hand by checking the configuration has changed after reload.

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

Copy link

codecov bot commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 76.92308% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 72.77%. Comparing base (22331f0) to head (76b0260).
Report is 8 commits behind head on master.

Files Patch % Lines
...va/org/jenkinsci/plugins/oic/OicSecurityRealm.java 76.92% 2 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##             master     #287      +/-   ##
============================================
+ Coverage     71.90%   72.77%   +0.86%     
+ Complexity      194      189       -5     
============================================
  Files             9        9              
  Lines           744      753       +9     
  Branches        124      116       -8     
============================================
+ Hits            535      548      +13     
+ Misses          150      146       -4     
  Partials         59       59              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-doubez michael-doubez merged commit f736bfe into jenkinsci:master Apr 3, 2024
18 checks passed
@michael-doubez michael-doubez deleted the fix-cve-2023-50770 branch April 3, 2024 20:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant