Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rework security realm config GUI #312

Merged
merged 1 commit into from
May 22, 2024

Conversation

michael-doubez
Copy link
Contributor

@michael-doubez michael-doubez commented May 2, 2024

Clarify config GUI and improve internationalization.
Fixes #295 GUI issue of configuring logout from provider when using well known configuration.

Testing done

Tested manually

Submitter checklist

Edit tasklist title
Beta Give feedback Tasklist Submitter checklist, more options

Delete tasklist

Delete tasklist block?
Are you sure? All relationships in this tasklist will be removed.
  1. Make sure you are opening from a topic/feature/bugfix branch (right side) and not your main branch!
    Options
  2. Ensure that the pull request title represents the desired changelog entry
    Options
  3. Please describe what you did
    Options
  4. Link to relevant issues in GitHub or Jira
    Options
  5. Link to relevant pull requests, esp. upstream and downstream changes
    Options
  6. Ensure you have provided tests - that demonstrates feature works or fixes the issue
    Options

@michael-doubez michael-doubez requested a review from a team as a code owner May 2, 2024 22:20
@michael-doubez michael-doubez self-assigned this May 2, 2024
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.32%. Comparing base (e327bf2) to head (8b7cd22).
Report is 16 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master     #312      +/-   ##
============================================
- Coverage     73.35%   73.32%   -0.04%     
  Complexity      211      211              
============================================
  Files            10       10              
  Lines           882      881       -1     
  Branches        124      124              
============================================
- Hits            647      646       -1     
  Misses          172      172              
  Partials         63       63              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@michael-doubez michael-doubez merged commit a7526f3 into jenkinsci:master May 22, 2024
17 of 18 checks passed
@michael-doubez michael-doubez deleted the realm-config-gui branch May 22, 2024 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login while on logout page displays misleading message
1 participant