Bump gmavenplus-plugin from 1.9.1 to 1.10.0

[dependabot-preview]

Bumps gmavenplus-plugin from 1.9.1 to 1.10.0.

Release notes

Sourced from gmavenplus-plugin's releases.

1.10.0

Bugs

None

Enhancements

• Change default GroovyDoc jar artifact type to javadoc, so its extension gets set to "jar" by the artifact handler instead of "groovydoc" by the default handler logic which uses the type for the extension in the case of unknown types (#151).

Potentially breaking changes

• GroovyDoc jars and test GroovyDoc jars will now be of type "javadoc" and have extension "jar".  Rather than type and extension "groovydoc".  If you do not wish to transition to this new behavior, set the new artifactType or testArtifactType property to "groovydoc" to revert to the previous behavior.

Notes

• While the artifact type of GroovyDoc jars has changed, the Maven classifier has not.  It remains "groovydoc", and you can still override that, just as before.

Commits

• 0c66126 [maven-release-plugin] prepare release 1.10.0
• 4d67a4c Bump Ant and Mockito versions
• 09fe24a Merge pull request #164 from groovy/151
• 1a23b2e Change GroovyDoc artifact type to javadoc (closes #151)
• 2555e97 Update test Groovy version
• 7d776c8 Add more Groovy versions to integration test
• ae78971 [maven-release-plugin] prepare for next development iteration
• See full diff in compare view

Dependabot will resolve any conflicts with this PR as long as you don't alter it yourself. You can also trigger a rebase manually by commenting @dependabot rebase.

---

Dependabot commands and options

You can trigger Dependabot actions by commenting on this PR:

• @dependabot rebase will rebase this PR
• @dependabot recreate will recreate this PR, overwriting any edits that have been made to it
• @dependabot merge will merge this PR after your CI passes on it
• @dependabot squash and merge will squash and merge this PR after your CI passes on it
• @dependabot cancel merge will cancel a previously requested merge and block automerging
• @dependabot reopen will reopen this PR if it is closed
• @dependabot close will close this PR and stop Dependabot recreating it. You can achieve the same result by closing it manually
• @dependabot badge me will comment on this PR with code to add a "Dependabot enabled" badge to your readme

Additionally, you can set the following in the .dependabot/config.yml file in this repo:

• Update frequency
• Automerge options (never/patch/minor, and dev/runtime dependencies)
• Out-of-range updates (receive only lockfile updates, if desired)
• Security updates (receive only security updates, if desired)

[jglick]

We need to add an IT for a sample plugin using Groovy sources. IIRC @bitwiseman added this originally? My personal preference is to remove this plugin and discourage anyone from using Groovy sources to begin with.

[bitwiseman]

@jglick

We need to add an IT for a sample plugin using Groovy sources. IIRC @bitwiseman added this originally?

It is less that I added this and more that I replaced the unmaintained gmaven-plugin with this. I did not have an integration test, but I had examples of downstream projects that worked. As noted in #209:

jenkinsci/workflow-cps-plugin#296
jenkinsci/htmlpublisher-plugin#42

My personal preference is to remove this plugin and discourage anyone from using Groovy sources to begin with.

That is not an option and repeating your preference each time this comes up doesn't change that. Do you feel it is worth organizing a group to make the change across all plugins that currently depend on this?

[jglick]

less that I added this and more that I replaced the unmaintained gmaven-plugin with this

Ah OK, thanks for refreshing my memory here.

I do not think an IT should be particularly difficult, just something that needs to be done to make maintenance more comfortable, like in #335 recently.

[jglick]

BTW jenkinsci/htmlpublisher-plugin#76. pipeline-model-definition is the last major plugin I can think of which actually uses compiled Groovy sources. (Not counting Groovy Stapler views or Pipeline script fragments in src/main/resources/, which are processed at runtime.) That has long been a serious headache in its maintenance, but translating to Java would be a big project due to the size of the source base.

[jglick]

@dependabot merge

🤷‍♂️ if it breaks something we will find out and create an IT I suppose.