Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ExtensionList error after dynamic load #552

Merged
merged 4 commits into from
Jan 4, 2024

Conversation

jglick
Copy link
Member

@jglick jglick commented Jan 3, 2024

Still problems with #549, due to an apparent core bug. One of many reasons I dislike GuiceFinder. jenkinsci/acceptance-test-harness#1463 (comment)

@jglick jglick added the bug label Jan 3, 2024
@jglick jglick changed the title ScriptApprovalLoadingTest ExtensionList error after dynamic load Jan 3, 2024
@jglick jglick requested a review from Vlatombe January 3, 2024 22:16
@jglick jglick marked this pull request as ready for review January 3, 2024 22:32
@jglick jglick requested a review from a team as a code owner January 3, 2024 22:32
@jglick jglick merged commit f24adfc into jenkinsci:master Jan 4, 2024
14 checks passed
@jglick jglick deleted the ScriptApprovalLoadingTest branch January 4, 2024 14:23
MarkEWaite added a commit to MarkEWaite/bom that referenced this pull request Jan 6, 2024
Test failure can be seen with script security 1310.vf24a_dfce068b_:

LINE=2.426.x PLUGINS=script-security TEST=ScriptApprovalLoadingTest bash local-test.sh

Test does not fail with script security 1305.v487433146192

Failure assumed to be a result of script security pull request:

* jenkinsci/script-security-plugin#552

Reverts pull request:

* jenkinsci#2796

This reverts commit f02d56c.
MarkEWaite added a commit to jenkinsci/bom that referenced this pull request Jan 6, 2024
Test failure can be seen with script security 1310.vf24a_dfce068b_:

LINE=2.426.x PLUGINS=script-security TEST=ScriptApprovalLoadingTest bash local-test.sh

Test does not fail with script security 1305.v487433146192

Failure assumed to be a result of script security pull request:

* jenkinsci/script-security-plugin#552

Reverts pull request:

* #2796

This reverts commit f02d56c.
@MarkEWaite
Copy link
Contributor

MarkEWaite commented Jan 6, 2024

@jglick the script security release that contains this pull request fails a test in the plugin bill of materials. I've prepared the revert pull request as:

Could you investigate the failure?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants