-
Notifications
You must be signed in to change notification settings - Fork 161
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ExtensionList
error after dynamic load
#552
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jglick
changed the title
Jan 3, 2024
ScriptApprovalLoadingTest
ExtensionList
error after dynamic load
Vlatombe
approved these changes
Jan 4, 2024
MarkEWaite
added a commit
to MarkEWaite/bom
that referenced
this pull request
Jan 6, 2024
Test failure can be seen with script security 1310.vf24a_dfce068b_: LINE=2.426.x PLUGINS=script-security TEST=ScriptApprovalLoadingTest bash local-test.sh Test does not fail with script security 1305.v487433146192 Failure assumed to be a result of script security pull request: * jenkinsci/script-security-plugin#552 Reverts pull request: * jenkinsci#2796 This reverts commit f02d56c.
MarkEWaite
added a commit
to jenkinsci/bom
that referenced
this pull request
Jan 6, 2024
Test failure can be seen with script security 1310.vf24a_dfce068b_: LINE=2.426.x PLUGINS=script-security TEST=ScriptApprovalLoadingTest bash local-test.sh Test does not fail with script security 1305.v487433146192 Failure assumed to be a result of script security pull request: * jenkinsci/script-security-plugin#552 Reverts pull request: * #2796 This reverts commit f02d56c.
@jglick the script security release that contains this pull request fails a test in the plugin bill of materials. I've prepared the revert pull request as: Could you investigate the failure? |
This was referenced Jan 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still problems with #549, due to an apparent core bug. One of many reasons I dislike
GuiceFinder
. jenkinsci/acceptance-test-harness#1463 (comment)