Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade plugin parent POM to 4.60 #458

Merged
merged 1 commit into from
Apr 25, 2023
Merged

Upgrade plugin parent POM to 4.60 #458

merged 1 commit into from
Apr 25, 2023

Conversation

basil
Copy link
Member

@basil basil commented Apr 19, 2023

Adapts to mockito/mockito#2945 by switching our dependency from mockito-inline to mockito-core.

@basil basil requested a review from a team as a code owner April 19, 2023 00:49
@timja
Copy link
Member

timja commented Apr 21, 2023

@jenkinsci/support-core-plugin-developers could this please be merged and released?

It's required for our effort to remove prototype.js from Jenkins core.
see jenkinsci/jenkins#7781 / jenkinsci/bom#1968

@timja
Copy link
Member

timja commented Apr 24, 2023

cc @jglick

@timja timja requested a review from jglick April 24, 2023 21:15
Copy link
Member

@jglick jglick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not have write permissions.

@basil
Copy link
Member Author

basil commented Apr 25, 2023

green-checkmark

👀

@jglick
Copy link
Member

jglick commented Apr 25, 2023

Yes, it is odd, because despite that
blocked
(Nor do I have admin permissions to see how the repo is configured.)

Anyway I have asked some people in @jenkinsci/support-core-plugin-developers to merge.

@jglick
Copy link
Member

jglick commented Apr 25, 2023

(Normally @Dohbedoh it seems.)

@Dohbedoh Dohbedoh merged commit 097a073 into jenkinsci:master Apr 25, 2023
16 checks passed
@Dohbedoh
Copy link
Contributor

@jglick you are part of https://github.com/jenkins-infra/repository-permissions-updater/blob/master/permissions/plugin-support-core.yml#L8-L18 and the you even have explicit Write permissions on the repo:

Screen Shot 2023-04-26 at 7 51 02 am

@Dohbedoh
Copy link
Contributor

Dohbedoh commented Apr 25, 2023

Oh but that YAML file is not in sync with https://github.com/orgs/jenkinsci/teams/support-core-plugin-developers.
And per the master branch protection rule "Restrict who can push to matching branches" Write permissions are not enough:

Organization administrators, repository administrators, and users with the Maintain role.
These members can push when required status checks pass.

@basil basil deleted the pom branch April 25, 2023 21:59
@Dohbedoh
Copy link
Contributor

@basil @timja sorry for the delay on that PR https://github.com/jenkinsci/support-core-plugin/releases/tag/1274.v097a_073e7733

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants