don't downcase the conditional in multijob job [JENKINS-27025] #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for a pull request! Please check this document for how the Jenkins project handles pull requests |
|
@itaior did you see this one ? |
| @@ -133,7 +133,7 @@ private int getScmChange(AbstractProject subjob, PhaseJobsConfig phaseConfig, Ab | |||
|
|
|||
| public boolean evalCondition(final String condition, final AbstractBuild<?, ?> build, final BuildListener listener) { | |||
| try { | |||
| return (Boolean) Eval.me(expandToken(condition, build, listener).toLowerCase().trim()); | |||
| return (Boolean) Eval.me(expandToken(condition, build, listener).trim()); | |||
There was a problem hiding this comment.
May break cases, which rely on the current behavior. Probably Eval should be made universal somehow
There was a problem hiding this comment.
@oleg-nenashev I'm not certain that the conditional functionality is usable while being lower cased. Most groovy code won't evaluate without correct capitalization.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is a fix for https://issues.jenkins-ci.org/browse/JENKINS-27025
I have not tested it but I see no reasons why this would not work.