Pause executions when terminating even when not quieting down #866
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…)` does not fix it, and test passes anyway
|
Managed to reproduce a stack trace, though not in fact involving CPS code: Not really successful attempt at reproduction |
|
While restarting a controller running while (true) {
sleep 1
}I did see Stack tracebut that seems expected. |
|
Had a job running like checkpoint 'x' // CloudBees CI
build job: JOB_NAME, wait: falseand pressed Ctrl-C on |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I observed a large stream of errors from a controller shutting down. This was part of a Kubernetes restart so the pod would have gotten a termination signal yet Jenkins is not “quieting down”.
Redacted examples of errors
From earlier log messages I know all this occurred after
suspendAll()completed. Yet by looking at the line numbers you can seeworkflow-cps-plugin/plugin/src/main/java/org/jenkinsci/plugins/workflow/cps/CpsThreadGroup.java
Line 331 in b3ff2ae
EXECUTIONS_SUSPENDEDmilestone (#766), we would not expect CPS chunks to still be run. Apparently they do not run well (the executor service has already been shut down, hence these errors), but perhaps the process is still writing other metadata files even aftercheckpointhas been asked to save everything for the last time.I could not figure out how to reproduce this situation in a test. The lack of pausing is reproduced easily in
JenkinsSessionRule.RealJenkinsRulenormally enters quiet-down mode which activates thePausing (Preparing for shutdown)message, but even without jenkinsci/jenkins-test-harness#544 you can simply replace a call tostopJenkinswithrunRemotelyonWhat I do not know how to reproduce is the
FatalRejectedExecutionExceptions shown above. What causes the program to trigger work during this time? Maybe I need to artificially slow down shutdown and then have someshsteps finish?