Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move copy button and update generate button #867

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Move copy button and update generate button #867

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
8 changes: 4 additions & 4 deletions plugin/src/main/resources/org/jenkinsci/plugins/workflow/cps/Snippetizer/index.jelly
View file
Open in desktop
Expand Up @@ -68,11 +68,11 @@ THE SOFTWARE.
<local:listSteps quasiDescriptors="${it.getQuasiDescriptors(true)}"/>
</f:dropdownList>
<f:block>
<input type="button" id="generatePipelineScript" value="${%Generate Pipeline Script}"
class="submit-button primary"
data-url="${rootURL}/${it.GENERATE_URL}"/>
<button class="jenkins-button jenkins-button--primary" id="generatePipelineScript"
data-url="${rootURL}/${it.GENERATE_URL}">${%Generate Pipeline Script}</button>
<nbsp/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

? if we need to wrap this button and the copy button does the UI not have more issues than this?
Does this even need a space, as the margin-left has been specified?

<l:copyButton text="" tooltip="${%Click to copy}" clazz="jenkins-!-margin-left-2"/>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this is now shown when there is nothing to copy - which seems like a UX issue (either the button should be hidden as now until the script has been generated, or the button should be disabled until there is something to copy)?

<f:textarea id="prototypeText" readonly="true" style="margin-top: 10px"/>
<l:copyButton text="" clazz="jenkins-hidden jenkins-!-margin-top-1"/>
<st:adjunct includes="org.jenkinsci.plugins.workflow.cps.Snippetizer.handle-prototype"/>
</f:block>
<f:section title="${%Global Variables}"/>
Expand Down