New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[JENKINS-30412] Offering a sandbox-friendly RunWrapper.changeSets property #5
[JENKINS-30412] Offering a sandbox-friendly RunWrapper.changeSets property #5
Conversation
</pluginRepository> | ||
</pluginRepositories> | ||
<properties> | ||
<jenkins.version>1.642.3</jenkins.version> | ||
<jenkins-test-harness.version>2.11</jenkins-test-harness.version> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Need getLog
fixed to be plain text.
This pull request originates from a CloudBees employee. At CloudBees, we require that all pull requests be reviewed by other CloudBees employees before we seek to have the change accepted. If you want to learn more about our process please see this explanation. |
🐝 Hurrah - been waiting for this. |
🐝 |
🐝 |
🐝 |
@jglick Many thanks for this one. Thanks. |
JENKINS-30412
Downstream of jenkinsci/script-security-plugin#78.
Also needs jenkinsci/pipeline-build-step-plugin#4 for documentation; I struggled to find a way for
BuildTriggerStep/help-wait.html
andRunWrapperBinder/help.jelly
tost:include
some common file fromworkflow-support
, but could not make it work. Specifiying justpath
throws an NPE fromIncludeTag
; you need to specify alsoclass
, but this is then not found since the class is in a plugin loader, not core. Not sure how this works. Could probably switch to Groovy views and do it somehow. Anyway, a topic for a future refactoring.@reviewbybees