Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #400

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Update README.md #400

wants to merge 1 commit into from

Conversation

EasyG0ing1
Copy link

Having this in the README would have saved me hours of frustration, I'm sure it could benefit others as well.

@EasyG0ing1
Update README.md
b13e3ea 
Having this in the README would have saved me hours of frustration, I'm sure it could benefit others as well.
mattcoleanderson
mattcoleanderson suggested changes Aug 11, 2023
View reviewed changes
Copy link

@mattcoleanderson mattcoleanderson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest moving this note further down the README.md near line 63 where the user is instructed to run the jenv doctor command. This command will error if JAVA_HOME is set. So the note goes well here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mattcoleanderson mattcoleanderson mattcoleanderson requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@EasyG0ing1 @mattcoleanderson