Skip to content

Commit

Permalink
chore: Use Node 18 (#360)
Browse files Browse the repository at this point in the history
* chore: use node 18

- Required upgrade to node-sass 8.0.0
- Required --openssl-legacy-provider
  - See: https://nodejs.org/en/blog/release/v17.0.0/#openssl-3-0
  - See: https://stackoverflow.com/a/69699772
  - See: https://github.blog/changelog/2022-09-22-github-actions-all-actions-will-begin-running-on-node16-instead-of-node12/

* fix: use --openssl-legacy-provider for build

* fix: update to non-deprecated MUI APIs

- See: actions/upload-artifact#351

- See: dorny/test-reporter#219

* chore: unpin GitHub action versions
  • Loading branch information
jeremyckahn committed Dec 30, 2022
1 parent 38b7a33 commit 9b40201
Show file tree
Hide file tree
Showing 10 changed files with 22,207 additions and 19,305 deletions.
8 changes: 4 additions & 4 deletions .github/workflows/ci.yml
Expand Up @@ -10,15 +10,15 @@ jobs:
test_and_build:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2.3.1
- uses: actions/checkout@v3
# https://stackoverflow.com/a/69634516
- name: Reconfigure git to use HTTP authentication
run: >
git config --global url."https://github.com/".insteadOf ssh://git@github.com/
- uses: actions/setup-node@v1
- uses: actions/setup-node@v3
with:
node-version: 14
- run: npm ci --no-optional --legacy-peer-deps
node-version: 18
- run: npm ci
- run: npm test -- --reporters=default --reporters=jest-junit
- name: Test Report
uses: dorny/test-reporter@v1
Expand Down
58 changes: 29 additions & 29 deletions .github/workflows/codeql-analysis.yml
Expand Up @@ -9,14 +9,14 @@
# the `language` matrix defined below to confirm you have the correct set of
# supported CodeQL languages.
#
name: "CodeQL"
name: 'CodeQL'

on:
push:
branches: [ develop ]
branches: [develop]
pull_request:
# The branches below must be a subset of the branches above
branches: [ develop ]
branches: [develop]
schedule:
- cron: '31 12 * * 2'

Expand All @@ -28,40 +28,40 @@ jobs:
strategy:
fail-fast: false
matrix:
language: [ 'javascript' ]
language: ['javascript']
# CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python' ]
# Learn more:
# https://docs.github.com/en/free-pro-team@latest/github/finding-security-vulnerabilities-and-errors-in-your-code/configuring-code-scanning#changing-the-languages-that-are-analyzed

steps:
- name: Checkout repository
uses: actions/checkout@v2
- name: Checkout repository
uses: actions/checkout@v3

# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v1
with:
languages: ${{ matrix.language }}
# If you wish to specify custom queries, you can do so here or in a config file.
# By default, queries listed here will override any specified in a config file.
# Prefix the list here with "+" to use these queries and those in the config file.
# queries: ./path/to/local/query, your-org/your-repo/queries@main
# Initializes the CodeQL tools for scanning.
- name: Initialize CodeQL
uses: github/codeql-action/init@v1
with:
languages: ${{ matrix.language }}
# If you wish to specify custom queries, you can do so here or in a config file.
# By default, queries listed here will override any specified in a config file.
# Prefix the list here with "+" to use these queries and those in the config file.
# queries: ./path/to/local/query, your-org/your-repo/queries@main

# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
# If this step fails, then you should remove it and run the build manually (see below)
- name: Autobuild
uses: github/codeql-action/autobuild@v1
# Autobuild attempts to build any compiled languages (C/C++, C#, or Java).
# If this step fails, then you should remove it and run the build manually (see below)
- name: Autobuild
uses: github/codeql-action/autobuild@v1

# ℹ️ Command-line programs to run using the OS shell.
# 📚 https://git.io/JvXDl
# ℹ️ Command-line programs to run using the OS shell.
# 📚 https://git.io/JvXDl

# ✏️ If the Autobuild fails above, remove it and uncomment the following three lines
# and modify them (or add more) to build your code if your project
# uses a compiled language
# ✏️ If the Autobuild fails above, remove it and uncomment the following three lines
# and modify them (or add more) to build your code if your project
# uses a compiled language

#- run: |
# make bootstrap
# make release
#- run: |
# make bootstrap
# make release

- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v1
- name: Perform CodeQL Analysis
uses: github/codeql-action/analyze@v1
2 changes: 1 addition & 1 deletion .github/workflows/notify-discord-about-update.yml
Expand Up @@ -9,7 +9,7 @@ jobs:
notify:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v2.3.1
- uses: actions/checkout@v3
with:
persist-credentials: false

Expand Down
20 changes: 10 additions & 10 deletions .github/workflows/run-release.yml
Expand Up @@ -14,7 +14,7 @@ jobs:
runs-on: ubuntu-latest
steps:
- name: Check out develop
uses: actions/checkout@v2.3.1
uses: actions/checkout@v3
with:
fetch-depth: 0
persist-credentials: true
Expand All @@ -29,12 +29,12 @@ jobs:
uses: fregante/setup-git-user@v1

- name: Setup Node
uses: actions/setup-node@v1
uses: actions/setup-node@v3
with:
node-version: 14
node-version: 18
registry-url: 'https://registry.npmjs.org'

- run: npm ci --no-optional --legacy-peer-deps
- run: npm ci

- name: Tag release
run: npm version ${{ github.event.inputs.releaseType }}
Expand All @@ -43,7 +43,7 @@ jobs:
- uses: nyaa8/package-version@v1

- name: Check out main
uses: actions/checkout@v2.3.1
uses: actions/checkout@v3
with:
clean: false
fetch-depth: 0
Expand Down Expand Up @@ -108,7 +108,7 @@ jobs:
# https://github.com/marketplace/actions/deploy-to-github-pages
- name: Deploy to jeremyckahn.github.io/farmhand
uses: JamesIves/github-pages-deploy-action@3.7.1
uses: JamesIves/github-pages-deploy-action@3
with:
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
BRANCH: gh-pages
Expand All @@ -123,7 +123,7 @@ jobs:
matrix:
os: [ubuntu-latest, macos-latest, windows-latest]
steps:
- uses: actions/checkout@v2.3.1
- uses: actions/checkout@v3
with:
fetch-depth: 0
persist-credentials: true
Expand All @@ -132,10 +132,10 @@ jobs:
- name: Reconfigure git to use HTTP authentication
run: >
git config --global url."https://github.com/".insteadOf ssh://git@github.com/
- uses: actions/setup-node@v1
- uses: actions/setup-node@v3
with:
node-version: 14
- run: npm ci --no-optional --legacy-peer-deps
node-version: 18
- run: npm ci
- name: 'Build and Release Electron App'
env:
GH_TOKEN: ${{ secrets.PERSONAL_ACCESS_TOKEN }}
Expand Down
3 changes: 3 additions & 0 deletions .npmrc
@@ -0,0 +1,3 @@
progress=false
legacy-peer-deps=true
no-optional=true
2 changes: 1 addition & 1 deletion .nvmrc
@@ -1 +1 @@
v14.17.0
v18.12.1

0 comments on commit 9b40201

Please sign in to comment.