Skip to content

Commit

Permalink
Always load experimental rules
Browse files Browse the repository at this point in the history
  • Loading branch information
lwasyl committed Jan 20, 2023
1 parent bbf3e25 commit bb1cc95
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 9 deletions.
Expand Up @@ -2,15 +2,12 @@ package org.jmailen.gradle.kotlinter.support

import com.pinterest.ktlint.core.RuleProvider
import com.pinterest.ktlint.core.RuleSetProviderV2
import com.pinterest.ktlint.ruleset.experimental.ExperimentalRuleSetProvider
import java.util.ServiceLoader

internal fun resolveRuleProviders(
providers: Iterable<RuleSetProviderV2>,
includeExperimentalRules: Boolean = false,
): Set<RuleProvider> = providers
.asSequence()
.filter { includeExperimentalRules || it !is ExperimentalRuleSetProvider }
.sortedWith(
compareBy {
when (it.id) {
Expand Down
Expand Up @@ -26,7 +26,7 @@ abstract class FormatWorkerAction : WorkAction<FormatWorkerParameters> {

override fun execute() {
val ktLintEngine = KtLintRuleEngine(
ruleProviders = resolveRuleProviders(defaultRuleSetProviders, ktLintParams.experimentalRules),
ruleProviders = resolveRuleProviders(defaultRuleSetProviders),
editorConfigOverride = editorConfigOverride(ktLintParams),
)

Expand Down
Expand Up @@ -31,7 +31,7 @@ abstract class LintWorkerAction : WorkAction<LintWorkerParameters> {

override fun execute() {
val ktLintEngine = KtLintRuleEngine(
ruleProviders = resolveRuleProviders(defaultRuleSetProviders, ktLintParams.experimentalRules),
ruleProviders = resolveRuleProviders(defaultRuleSetProviders),
editorConfigOverride = editorConfigOverride(ktLintParams),
)

Expand Down
Expand Up @@ -13,11 +13,9 @@ class RuleSetsTest {

@Test
fun `resolveRuleSets loads from classpath providers`() {
val standardOnly = resolveRuleProviders(defaultRuleSetProviders, includeExperimentalRules = false)
val withExperimentalRules = resolveRuleProviders(defaultRuleSetProviders, includeExperimentalRules = true)
val rules = resolveRuleProviders(defaultRuleSetProviders)

assertTrue(standardOnly.isNotEmpty())
assertTrue(standardOnly.size < withExperimentalRules.size)
assertTrue(rules.isNotEmpty())
}

@Test
Expand Down

0 comments on commit bb1cc95

Please sign in to comment.