Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve CommandHelper class #1283

Merged
merged 6 commits into from
May 22, 2024
Merged

Improve CommandHelper class #1283

merged 6 commits into from
May 22, 2024

Conversation

dfsmania
Copy link
Collaborator

@dfsmania dfsmania commented May 18, 2024 •
edited

Question Answer
Pull request type ENHANCEMENT
License MIT

What's in this PR?

  • Replace own implementation of EnsureDirectoryExists() by the one provided by the File facade.
  • Replace own implementation of removeDirectory() by the one provided by the File facade.
  • Improve logic on copyDirectories(), now returns a boolean when failing. Scrutinizer rating is also improved.
  • Improve logic on compareDirectories(). Scrutinizer rating is also improved.
  • Improve testing over this class.

Checklist

  • I tested these changes.

@dfsmania dfsmania marked this pull request as draft May 18, 2024 16:00
@dfsmania dfsmania changed the title Improve CommandHelper Improve CommandHelper class May 21, 2024
@dfsmania dfsmania marked this pull request as ready for review May 21, 2024 22:13
@dfsmania dfsmania requested a review from resslinger May 21, 2024 22:13
@resslinger resslinger merged commit 3fd7820 into jeroennoten:master May 22, 2024
34 checks passed
@dfsmania dfsmania deleted the improve_command_helper branch May 22, 2024 13:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@resslinger resslinger resslinger approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dfsmania @resslinger