Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes nuttx target warning #4984

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fixes nuttx target warning #4984

wants to merge 1 commit into from

Conversation

lygstate
Copy link
Contributor 

jerry-main.c: In function 'str_to_uint':
jerry-main.c:89:12: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   89 |     *out_p = num_str_p;
make[4]: Leaving directory '/home/runner/work/jerryscript/jerryscript/targets/os/nuttx'
make[3]: Leaving directory '/home/runner/work/jerryscript/apps'

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com

@rtakacs
Copy link
Contributor

rtakacs commented Feb 22, 2022

Good catch! I think, it's better to remove that parameter since str_to_num is used only once at jerry-main.c:179 with NULL argument for out_p.

@lygstate
Fixes nuttx target warning
969b681 
```
jerry-main.c: In function 'str_to_uint':
jerry-main.c:89:12: warning: assignment discards 'const' qualifier from pointer target type [-Wdiscarded-qualifiers]
   89 |     *out_p = num_str_p;
make[4]: Leaving directory '/home/runner/work/jerryscript/jerryscript/targets/os/nuttx'
make[3]: Leaving directory '/home/runner/work/jerryscript/apps'
```

JerryScript-DCO-1.0-Signed-off-by: Yonggang Luo luoyonggang@gmail.com
@rtakacs
Copy link
Contributor

rtakacs commented Mar 2, 2022

LGTM (informal)

robertsipka
robertsipka approved these changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@robertsipka robertsipka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ossy-szeged
ossy-szeged requested changes Mar 2, 2022
View reviewed changes
Copy link
Contributor

@ossy-szeged ossy-szeged left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but it would be great to have a formal commit message, we don"t put complete build logs to the commit messages.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ossy-szeged ossy-szeged ossy-szeged requested changes

@robertsipka robertsipka robertsipka approved these changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@lygstate @rtakacs @ossy-szeged @robertsipka