Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add nerdfont icons for .bicep & .bicepparam files #3053

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

scottmckendry
Copy link

  • PR Description
    As the title says, I've added the v3 nerd font icons for Bicep.

  • Please check if the PR fulfills these requirements

  • Cheatsheets are up-to-date (run go generate ./...)
  • Code has been formatted (see here)
  • Tests have been added/updated (see here for the integration test guide)
  • Text is internationalised (see here)
  • Docs (specifically docs/Config.md) have been updated if necessary
  • You've read through your own file changes for silly mistakes etc

@mark2185 mark2185 added enhancement New feature or request requires-maintainer-signoff PR is reviewed but requires final signoff labels Dec 1, 2023
@mark2185
Copy link
Collaborator

mark2185 commented Dec 1, 2023

@scottmckendry could you please rebase this and resolve the conflicts, if you're up for it?

@mark2185 mark2185 removed the requires-maintainer-signoff PR is reviewed but requires final signoff label Dec 1, 2023
@scottmckendry scottmckendry reopened this Dec 1, 2023
@scottmckendry
Copy link
Author

@mark2185 done - I'm not sure about colours, however. Bicep doesn't have very distinct branding so I've sort of picked these at random.

Happy for these to be updated to whatever. I have no preference at all when it comes to colours, as long as it's easy to see the difference between the two file types (given they share an icon).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants