feat: support file URLs #193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
commented
Mar 6, 2023
| @@ -78,7 +78,7 @@ export default function createRunner< | |||
| onFailure: OnTestFailure, | |||
| options: TestRunnerOptions, | |||
| ): Promise<void> { | |||
| const runner: TestRunner = (await import(runPath)).default; | |||
| const runner: TestRunner = (await import(runPath.toString())).default; | |||
There was a problem hiding this comment.
TS believes this must be a string, which is wrong. But it's also fine to just stringify it (since it's transpiled to require it's probably a good idea)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It might make more sense to just change the type here, but implement conversion injest-worker.EDIT: jestjs/jest#13982