refactor: optimize a little further

jest-community · Nov 4, 2022 · 3431af2 · 3431af2
1 parent d6a1130
commit 3431af2
Showing 1 changed file with 5 additions and 6 deletions.
diff --git a/src/rules/utils/parseJestFnCall.ts b/src/rules/utils/parseJestFnCall.ts
@@ -585,7 +585,6 @@ export const scopeHasLocalReference = (
   scope: TSESLint.Scope.Scope,
   referenceName: string,
 ) => {
-  let unresolved = false;
   let currentScope: TSESLint.Scope.Scope | null = scope;
 
   while (currentScope !== null) {
@@ -609,14 +608,14 @@ export const scopeHasLocalReference = (
       }
     }
 
-    if (!unresolved) {
-      for (const ref of currentScope.through) {
-        unresolved = ref.identifier.name !== referenceName;
-      }
+    if (
+      currentScope.through.every(ref => ref.identifier.name !== referenceName)
+    ) {
+      return true;
     }
 
     currentScope = currentScope.upper;
   }
 
-  return unresolved;
+  return false;
 };