fix: adjust code to cover branches

jest-community · Apr 30, 2022 · 3601ceb · 3601ceb
1 parent e76e724
commit 3601ceb
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 7 deletions.
diff --git a/src/rules/__tests__/utils.test.ts b/src/rules/__tests__/utils.test.ts
@@ -666,6 +666,14 @@ describe('reference checking', () => {
         `,
         parserOptions: { sourceType: 'script' },
       },
+      {
+        code: dedent`
+          const { [() => {}]: it } = require('@jest/globals');
+
+          it('is not a jest function', () => {});
+        `,
+        parserOptions: { sourceType: 'script' },
+      },
     ],
     invalid: [
       {

diff --git a/src/rules/utils.ts b/src/rules/utils.ts
@@ -829,19 +829,14 @@ const describeVariableDefAsImport = (
     return null;
   }
 
-  // currently we only support access via destructuring
-  if (def.node.id.type !== AST_NODE_TYPES.ObjectPattern) {
-    return null;
-  }
-
   const sourceNode = findImportSourceNode(def.node.init);
 
   if (!sourceNode || !isStringNode(sourceNode)) {
     return null;
   }
 
   if (def.name.parent?.type !== AST_NODE_TYPES.Property) {
-    throw new Error('oh noes!');
+    return null;
   }
 
   if (!isSupportedAccessor(def.name.parent.key)) {
@@ -890,8 +885,11 @@ const collectReferences = (scope: TSESLint.Scope.Scope) => {
         continue;
       }
 
+      /* istanbul ignore if */
       if (ref.defs.length > 1) {
-        throw new Error('please report this');
+        throw new Error(
+          `Reference unexpected had more than one definition - please file a github issue at https://github.com/jest-community/eslint-plugin-jest`,
+        );
       }
 
       const [def] = ref.defs;