fix: apply suggestions from code review

Co-authored-by: Gareth Jones <Jones258@Gmail.com> Co-authored-by: Simen Bekkhus <sbekkhus91@gmail.com>
jest-community · Jul 6, 2020 · 3738c2d · 3738c2d
1 parent 3fcf261
commit 3738c2d
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 4 deletions.
diff --git a/docs/rules/no-interpolation-in-snapshots.md b/docs/rules/no-interpolation-in-snapshots.md
@@ -1,4 +1,4 @@
-# Disallow string interpolation inside inline snapshots (`no-interpolation-in-snapshots`)
+# Disallow string interpolation inside snapshots (`no-interpolation-in-snapshots`)
 
 Prevents the use of string interpolations in snapshots.
 

diff --git a/src/rules/no-interpolation-in-snapshots.ts b/src/rules/no-interpolation-in-snapshots.ts
@@ -6,15 +6,15 @@ export default createRule({
   meta: {
     docs: {
       category: 'Best Practices',
-      description: 'Disallow string interpolation inside inline snapshots.',
+      description: 'Disallow string interpolation inside inline snapshots',
       recommended: false,
     },
     messages: {
       noInterpolation:
         'Do not use string interpolation inside of inline snapshots',
     },
     schema: [],
-    type: 'suggestion',
+    type: 'problem',
   },
   defaultOptions: [],
   create(context) {
@@ -26,8 +26,11 @@ export default createRule({
 
         const { matcher } = parseExpectCall(node);
 
+        if (!matcher) {
+          return;
+        }
+
         if (
-          matcher &&
           [
             'toMatchInlineSnapshot',
             'toThrowErrorMatchingInlineSnapshot',