feat: add no-deprecated-functions to the recommended ruleset

BREAKING CHANGE: recommend `no-deprecated-functions` rule
jest-community · Sep 4, 2020 · 5b2af00 · 5b2af00
1 parent 41f7873
commit 5b2af00
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 2 deletions.
diff --git a/README.md b/README.md
@@ -136,7 +136,7 @@ installations requiring long-term consistency.
 | [no-alias-methods](docs/rules/no-alias-methods.md)                           | Disallow alias methods                                          | ![style][]       | ![fixable][] |
 | [no-commented-out-tests](docs/rules/no-commented-out-tests.md)               | Disallow commented out tests                                    | ![recommended][] |              |
 | [no-conditional-expect](docs/rules/no-conditional-expect.md)                 | Prevent calling `expect` conditionally                          |                  |              |
-| [no-deprecated-functions](docs/rules/no-deprecated-functions.md)             | Disallow use of deprecated functions                            |                  | ![fixable][] |
+| [no-deprecated-functions](docs/rules/no-deprecated-functions.md)             | Disallow use of deprecated functions                            | ![recommended][] | ![fixable][] |
 | [no-disabled-tests](docs/rules/no-disabled-tests.md)                         | Disallow disabled tests                                         | ![recommended][] |              |
 | [no-duplicate-hooks](docs/rules/no-duplicate-hooks.md)                       | Disallow duplicate setup and teardown hooks                     |                  |              |
 | [no-export](docs/rules/no-export.md)                                         | Disallow using `exports` in files containing tests              | ![recommended][] |              |

diff --git a/src/__tests__/__snapshots__/rules.test.ts.snap b/src/__tests__/__snapshots__/rules.test.ts.snap
@@ -66,6 +66,7 @@ Object {
     "rules": Object {
       "jest/expect-expect": "warn",
       "jest/no-commented-out-tests": "warn",
+      "jest/no-deprecated-functions": "error",
       "jest/no-disabled-tests": "warn",
       "jest/no-export": "error",
       "jest/no-focused-tests": "error",

diff --git a/src/rules/no-deprecated-functions.ts b/src/rules/no-deprecated-functions.ts
@@ -66,7 +66,7 @@ export default createRule({
     docs: {
       category: 'Best Practices',
       description: 'Disallow use of deprecated functions',
-      recommended: false,
+      recommended: 'error',
     },
     messages: {
       deprecatedFunction: