fix(valid-describe): don't check arguments of describe.each

Fixes #463
jest-community · Oct 31, 2019 · 63472e2 · 63472e2
1 parent 2224c95
commit 63472e2
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 1 deletion.
diff --git a/src/rules/__tests__/valid-describe.test.ts b/src/rules/__tests__/valid-describe.test.ts
@@ -16,6 +16,7 @@ ruleTester.run('valid-describe', rule, {
     'describe["each"](() => {})("foo")',
     'describe["each"]()(() => {})',
     'describe["each"]("foo")(() => {})',
+    'describe.each([1, 2, 3])("%s", (a, b) => {});',
     'describe("foo", function() {})',
     'describe("foo", () => {})',
     'describe(`foo`, () => {})',

diff --git a/src/rules/valid-describe.ts b/src/rules/valid-describe.ts
@@ -6,6 +6,7 @@ import {
   createRule,
   getJestFunctionArguments,
   isDescribe,
+  isDescribeEach,
   isFunction,
 } from './utils';
 
@@ -85,7 +86,7 @@ export default createRule({
           });
         }
 
-        if (callback.params.length) {
+        if (!isDescribeEach(node) && callback.params.length) {
           context.report({
             messageId: 'unexpectedDescribeArgument',
             loc: paramsLocation(callback.params),