chore: add no-negated-condition lint rule

jest-community · Aug 6, 2019 · 85e4195 · 85e4195
1 parent d285f8b
commit 85e4195
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 3 deletions.
diff --git a/.eslintrc.js b/.eslintrc.js
@@ -30,6 +30,7 @@ module.exports = {
     '@typescript-eslint/ban-ts-ignore': 'warn',
     '@typescript-eslint/ban-types': 'error',
     'no-else-return': 'error',
+    'no-negated-condition': 'error',
     eqeqeq: ['error', 'smart'],
     strict: 'error',
     'prefer-template': 'warn',

diff --git a/src/rules/prefer-expect-assertions.js b/src/rules/prefer-expect-assertions.js
@@ -54,13 +54,13 @@ export default {
       'CallExpression[callee.name=/^(it|test)$/][arguments.1.body.body]'(node) {
         const testFuncBody = node.arguments[1].body.body;
 
-        if (!isFirstLineExprStmt(testFuncBody)) {
-          reportMsg(context, node);
-        } else {
+        if (isFirstLineExprStmt(testFuncBody)) {
           const testFuncFirstLine = getFunctionFirstLine(testFuncBody);
           if (!isExpectAssertionsOrHasAssertionsCall(testFuncFirstLine)) {
             reportMsg(context, node);
           }
+        } else {
+          reportMsg(context, node);
         }
       },
     };