fix(max-expects): properly reset counter when exiting a test case (#1550

)
jest-community · Apr 6, 2024 · b4b7cbc · b4b7cbc
1 parent 6aaabc4
commit b4b7cbc
Show file tree

Hide file tree

Showing 2 changed files with 233 additions and 0 deletions.
diff --git a/src/rules/__tests__/max-expects.test.ts b/src/rules/__tests__/max-expects.test.ts
@@ -119,6 +119,39 @@ ruleTester.run('max-expects', rule, {
         expect(true).toBeDefined();
       });
     `,
+    dedent`
+      test('should not pass', () => {
+        const checkValue = (value) => {
+          expect(value).toBeDefined();
+          expect(value).toBeDefined();
+        };
+
+        checkValue(true);
+      });
+      test('should not pass', () => {
+        expect(true).toBeDefined();
+        expect(true).toBeDefined();
+        expect(true).toBeDefined();
+      });
+    `,
+    dedent`
+      test('should not pass', done => {
+        emitter.on('event', value => {
+          expect(value).toBeDefined();
+          expect(value).toBeDefined();
+          expect(value).toBeDefined();
+          expect(value).toBeDefined();
+
+          done();
+        });
+      });
+      test('should not pass', () => {
+        expect(true).toBeDefined();
+        expect(true).toBeDefined();
+        expect(true).toBeDefined();
+        expect(true).toBeDefined();
+      });
+    `,
     dedent`
       function myHelper() {
         expect(true).toBeDefined();
@@ -204,6 +237,24 @@ ruleTester.run('max-expects', rule, {
         },
       ],
     },
+    {
+      code: dedent`
+        describe('given decimal places', () => {
+          it("test 1", fakeAsync(() => {
+            expect(true).toBeTrue();
+            expect(true).toBeTrue();
+            expect(true).toBeTrue();
+          }))
+
+          it("test 2", fakeAsync(() => {
+            expect(true).toBeTrue();
+            expect(true).toBeTrue();
+            expect(true).toBeTrue();
+          }))
+        })
+      `,
+      options: [{ max: 5 }],
+    },
   ],
   invalid: [
     {
@@ -314,6 +365,184 @@ ruleTester.run('max-expects', rule, {
         },
       ],
     },
+    {
+      code: dedent`
+        test('should not pass', () => {
+          const checkValue = (value) => {
+            expect(value).toBeDefined();
+            expect(value).toBeDefined();
+          };
+
+          checkValue(true);
+        });
+        test('should not pass', () => {
+          expect(true).toBeDefined();
+          expect(true).toBeDefined();
+          expect(true).toBeDefined();
+        });
+      `,
+      options: [{ max: 1 }],
+      errors: [
+        {
+          messageId: 'exceededMaxAssertion',
+          line: 4,
+          column: 5,
+        },
+        {
+          messageId: 'exceededMaxAssertion',
+          line: 11,
+          column: 3,
+        },
+        {
+          messageId: 'exceededMaxAssertion',
+          line: 12,
+          column: 3,
+        },
+      ],
+    },
+    {
+      code: dedent`
+        test('should not pass', () => {
+          const checkValue = (value) => {
+            expect(value).toBeDefined();
+            expect(value).toBeDefined();
+          };
+
+          checkValue(true);
+        });
+        test('should not pass', () => {
+          expect(true).toBeDefined();
+          expect(true).toBeDefined();
+          expect(true).toBeDefined();
+        });
+      `,
+      options: [{ max: 2 }],
+      errors: [
+        {
+          messageId: 'exceededMaxAssertion',
+          line: 12,
+          column: 3,
+        },
+      ],
+    },
+    {
+      code: dedent`
+        test('should not pass', () => {
+          const checkValue = (value) => {
+            expect(value).toBeDefined();
+            expect(value).toBeDefined();
+          };
+
+          expect(value).toBeDefined();
+          checkValue(true);
+        });
+        test('should not pass', () => {
+          expect(true).toBeDefined();
+          expect(true).toBeDefined();
+          expect(true).toBeDefined();
+        });
+      `,
+      options: [{ max: 2 }],
+      errors: [
+        {
+          messageId: 'exceededMaxAssertion',
+          line: 13,
+          column: 3,
+        },
+      ],
+    },
+    {
+      code: dedent`
+        test('should not pass', done => {
+          emitter.on('event', value => {
+            expect(value).toBeDefined();
+            expect(value).toBeDefined();
+
+            done();
+          });
+        });
+        test('should not pass', () => {
+          expect(true).toBeDefined();
+          expect(true).toBeDefined();
+          expect(true).toBeDefined();
+        });
+      `,
+      options: [{ max: 1 }],
+      errors: [
+        {
+          messageId: 'exceededMaxAssertion',
+          line: 4,
+          column: 5,
+        },
+        {
+          messageId: 'exceededMaxAssertion',
+          line: 11,
+          column: 3,
+        },
+        {
+          messageId: 'exceededMaxAssertion',
+          line: 12,
+          column: 3,
+        },
+      ],
+    },
+    {
+      code: dedent`
+        test('should not pass', done => {
+          emitter.on('event', value => {
+            expect(value).toBeDefined();
+            expect(value).toBeDefined();
+
+            done();
+          });
+        });
+        test('should not pass', () => {
+          expect(true).toBeDefined();
+          expect(true).toBeDefined();
+          expect(true).toBeDefined();
+        });
+      `,
+      options: [{ max: 2 }],
+      errors: [
+        {
+          messageId: 'exceededMaxAssertion',
+          line: 12,
+          column: 3,
+        },
+      ],
+    },
+    {
+      code: dedent`
+        describe('given decimal places', () => {
+          it("test 1", fakeAsync(() => {
+            expect(true).toBeTrue();
+            expect(true).toBeTrue();
+            expect(true).toBeTrue();
+          }))
+
+          it("test 2", fakeAsync(() => {
+            expect(true).toBeTrue();
+            expect(true).toBeTrue();
+            expect(true).toBeTrue();
+            expect(true).toBeTrue();
+            expect(true).toBeTrue();
+          }))
+        })
+      `,
+      options: [{ max: 3 }],
+      errors: [
+        {
+          messageId: 'exceededMaxAssertion',
+          line: 12,
+          column: 5,
+        },
+        {
+          messageId: 'exceededMaxAssertion',
+          line: 13,
+          column: 5,
+        },
+      ],
+    },
     {
       code: dedent`
         describe('test', () => {

diff --git a/src/rules/max-expects.ts b/src/rules/max-expects.ts
@@ -52,6 +52,10 @@ export default createRule({
       CallExpression(node) {
         const jestFnCall = parseJestFnCall(node, context);
 
+        if (jestFnCall?.type === 'test') {
+          count = 0;
+        }
+
         if (
           jestFnCall?.type !== 'expect' ||
           jestFnCall.head.node.parent?.type === AST_NODE_TYPES.MemberExpression