chore(no-if): messageId noConditionalExpect -> conditionalInTest

jest-community · May 17, 2020 · ed341a6 · ed341a6
1 parent 6d1eda8
commit ed341a6
Show file tree

Hide file tree

Showing 2 changed files with 45 additions and 46 deletions.
diff --git a/src/rules/__tests__/no-if.test.ts b/src/rules/__tests__/no-if.test.ts
@@ -31,7 +31,7 @@ ruleTester.run('conditional expressions', rule, {
       errors: [
         {
           data: { condition: 'conditional' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -44,7 +44,7 @@ ruleTester.run('conditional expressions', rule, {
       errors: [
         {
           data: { condition: 'conditional' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -57,11 +57,11 @@ ruleTester.run('conditional expressions', rule, {
       errors: [
         {
           data: { condition: 'conditional' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
         {
           data: { condition: 'conditional' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -187,7 +187,7 @@ ruleTester.run('switch statements', rule, {
       errors: [
         {
           data: { condition: 'switch' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -198,7 +198,7 @@ ruleTester.run('switch statements', rule, {
       errors: [
         {
           data: { condition: 'switch' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -209,7 +209,7 @@ ruleTester.run('switch statements', rule, {
       errors: [
         {
           data: { condition: 'switch' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -220,7 +220,7 @@ ruleTester.run('switch statements', rule, {
       errors: [
         {
           data: { condition: 'switch' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -231,7 +231,7 @@ ruleTester.run('switch statements', rule, {
       errors: [
         {
           data: { condition: 'switch' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -242,7 +242,7 @@ ruleTester.run('switch statements', rule, {
       errors: [
         {
           data: { condition: 'switch' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -253,7 +253,7 @@ ruleTester.run('switch statements', rule, {
       errors: [
         {
           data: { condition: 'switch' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -264,7 +264,7 @@ ruleTester.run('switch statements', rule, {
       errors: [
         {
           data: { condition: 'switch' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -275,7 +275,7 @@ ruleTester.run('switch statements', rule, {
       errors: [
         {
           data: { condition: 'switch' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -286,7 +286,7 @@ ruleTester.run('switch statements', rule, {
       errors: [
         {
           data: { condition: 'switch' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -297,7 +297,7 @@ ruleTester.run('switch statements', rule, {
       errors: [
         {
           data: { condition: 'switch' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -308,7 +308,7 @@ ruleTester.run('switch statements', rule, {
       errors: [
         {
           data: { condition: 'switch' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -319,7 +319,7 @@ ruleTester.run('switch statements', rule, {
       errors: [
         {
           data: { condition: 'switch' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -332,7 +332,7 @@ ruleTester.run('switch statements', rule, {
       errors: [
         {
           data: { condition: 'switch' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -341,7 +341,7 @@ ruleTester.run('switch statements', rule, {
       errors: [
         {
           data: { condition: 'switch' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -358,15 +358,15 @@ ruleTester.run('switch statements', rule, {
       errors: [
         {
           data: { condition: 'switch' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
         {
           data: { condition: 'switch' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
         {
           data: { condition: 'switch' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -379,7 +379,7 @@ ruleTester.run('switch statements', rule, {
       errors: [
         {
           data: { condition: 'switch' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -408,7 +408,7 @@ ruleTester.run('switch statements', rule, {
       errors: [
         {
           data: { condition: 'switch' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -559,7 +559,7 @@ ruleTester.run('if statements', rule, {
       errors: [
         {
           data: { condition: 'if' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -570,7 +570,7 @@ ruleTester.run('if statements', rule, {
       errors: [
         {
           data: { condition: 'if' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -581,7 +581,7 @@ ruleTester.run('if statements', rule, {
       errors: [
         {
           data: { condition: 'if' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -592,7 +592,7 @@ ruleTester.run('if statements', rule, {
       errors: [
         {
           data: { condition: 'if' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -603,7 +603,7 @@ ruleTester.run('if statements', rule, {
       errors: [
         {
           data: { condition: 'if' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -614,7 +614,7 @@ ruleTester.run('if statements', rule, {
       errors: [
         {
           data: { condition: 'if' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -625,7 +625,7 @@ ruleTester.run('if statements', rule, {
       errors: [
         {
           data: { condition: 'if' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -636,7 +636,7 @@ ruleTester.run('if statements', rule, {
       errors: [
         {
           data: { condition: 'if' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -647,7 +647,7 @@ ruleTester.run('if statements', rule, {
       errors: [
         {
           data: { condition: 'if' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -658,7 +658,7 @@ ruleTester.run('if statements', rule, {
       errors: [
         {
           data: { condition: 'if' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -669,7 +669,7 @@ ruleTester.run('if statements', rule, {
       errors: [
         {
           data: { condition: 'if' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -680,7 +680,7 @@ ruleTester.run('if statements', rule, {
       errors: [
         {
           data: { condition: 'if' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -693,7 +693,7 @@ ruleTester.run('if statements', rule, {
       errors: [
         {
           data: { condition: 'if' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -702,7 +702,7 @@ ruleTester.run('if statements', rule, {
       errors: [
         {
           data: { condition: 'if' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -719,15 +719,15 @@ ruleTester.run('if statements', rule, {
       errors: [
         {
           data: { condition: 'if' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
         {
           data: { condition: 'if' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
         {
           data: { condition: 'if' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -740,7 +740,7 @@ ruleTester.run('if statements', rule, {
       errors: [
         {
           data: { condition: 'if' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },
@@ -767,7 +767,7 @@ ruleTester.run('if statements', rule, {
       errors: [
         {
           data: { condition: 'if' },
-          messageId: 'noConditionalExpect',
+          messageId: 'conditionalInTest',
         },
       ],
     },

diff --git a/src/rules/no-if.ts b/src/rules/no-if.ts
@@ -43,8 +43,7 @@ export default createRule({
       recommended: false,
     },
     messages: {
-      noConditionalExpect:
-        'Test should not contain {{ condition }} statements.',
+      conditionalInTest: 'Test should not contain {{ condition }} statements.',
     },
     schema: [],
     type: 'suggestion',
@@ -67,7 +66,7 @@ export default createRule({
 
       context.report({
         data: { condition: conditionName[node.type] },
-        messageId: 'noConditionalExpect',
+        messageId: 'conditionalInTest',
         node,
       });
     }