Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

no-large-snapshots should not care about file types #370

Closed
G-Rath opened this issue Aug 6, 2019 · 4 comments
Closed

no-large-snapshots should not care about file types #370

G-Rath opened this issue Aug 6, 2019 · 4 comments
Assignees
@G-Rath
Labels
enhancement released

Comments

@G-Rath
Copy link
Collaborator

G-Rath commented Aug 6, 2019 •
edited by SimenB

Currently, no-large-snapshots checks if the file being linted ends w/ the .js file extension, preventing it from linting other files, such as .tsx, .ts, & .jsx.

This file check should be removed.

eslint-plugin-jest/src/rules/no-large-snapshots.js

Line 88 in 85e4195

} else if (context.getFilename().endsWith('.js')) {

@G-Rath G-Rath self-assigned this Aug 6, 2019
@G-Rath G-Rath mentioned this issue Aug 6, 2019
Closed
G-Rath added a commit that referenced this issue Aug 6, 2019
@G-Rath
chore(no-large-snapshots): break todo out into #370
17fc8a8
@SimenB
Copy link
Member

SimenB commented Aug 6, 2019

Potentially a breaking change, but I'd call it a bugfix...

It was added in #186, @JohanBrorson thoughts on just removing the check? We should just return from the .snap if

@G-Rath
Copy link
Collaborator Author

G-Rath commented Aug 6, 2019

I can confirm that it does mean .ts files won't be linted by this rule.

Aside from that, I wouldn't really call it "breaking" per say, for the same reason prefer-to-spyon shouldn't bother trying to figure out if it's in a test file: eslint-plugin-jest is only meant for jest tests suites.

G-Rath added a commit that referenced this issue Aug 6, 2019
@G-Rath
chore(no-large-snapshots): break todo out into #370
6a8d56a
SimenB pushed a commit that referenced this issue Aug 6, 2019
@G-Rath @SimenB
chore(no-large-snapshots): break todo out into #370
383bf1d
G-Rath added a commit that referenced this issue Aug 8, 2019
@G-Rath
chore(no-large-snapshots): break todo out into #370
80a29f1
G-Rath added a commit that referenced this issue Aug 10, 2019
@G-Rath
chore(no-large-snapshots): break todo out into #370
faa70e5
G-Rath added a commit that referenced this issue Aug 11, 2019
@G-Rath
chore(no-large-snapshots): break todo out into #370
318072e
G-Rath added a commit that referenced this issue Aug 11, 2019
@G-Rath
chore(no-large-snapshots): break todo out into #370
a39a921
G-Rath added a commit that referenced this issue Aug 11, 2019
@G-Rath
chore(no-large-snapshots): break todo out into #370
5534609
G-Rath added a commit that referenced this issue Aug 11, 2019
@G-Rath
chore(no-large-snapshots): break todo out into #370
c861a27
@graphan
Copy link

graphan commented May 14, 2020

@G-Rath, @SimenB, @JohanBrorson We have our tests written in TypeScript, so we need it to be fixed. I created the following PR: #581
It is not passing due to some reason though, could you take a look?

@graphan graphan mentioned this issue May 14, 2020
Closed
G-Rath added a commit that referenced this issue Aug 2, 2020
@G-Rath
fix(no-large-snapshots): run on all files regardless of type
5302363 
BREAKING CHANGE

closes #370
closes #581
G-Rath added a commit that referenced this issue Aug 2, 2020
@G-Rath
fix(no-large-snapshots): run on all files regardless of type
bba35d0 
BREAKING CHANGE

closes #370
closes #581
@G-Rath G-Rath mentioned this issue Aug 2, 2020
Merged
SimenB pushed a commit that referenced this issue Aug 8, 2020
@G-Rath
fix(no-large-snapshots): run on all files regardless of type (#637)
cd285da 
BREAKING CHANGE: `no-large-snapshots` runs on all files regardless of type 

Fixes #370
SimenB pushed a commit that referenced this issue Aug 22, 2020
@G-Rath @SimenB
fix(no-large-snapshots): run on all files regardless of type (#637)
f9084aa 
BREAKING CHANGE: `no-large-snapshots` runs on all files regardless of type 

Fixes #370
SimenB pushed a commit that referenced this issue Aug 22, 2020
@G-Rath @SimenB
fix(no-large-snapshots): run on all files regardless of type (#637)
0b606ee 
BREAKING CHANGE: `no-large-snapshots` runs on all files regardless of type 

Fixes #370
SimenB pushed a commit that referenced this issue Aug 24, 2020
@G-Rath @SimenB
fix(no-large-snapshots): run on all files regardless of type (#637)
a99e9ae 
BREAKING CHANGE: `no-large-snapshots` runs on all files regardless of type 

Fixes #370
SimenB pushed a commit that referenced this issue Aug 24, 2020
@G-Rath @SimenB
fix(no-large-snapshots): run on all files regardless of type (#637)
0f734b1 
BREAKING CHANGE: `no-large-snapshots` runs on all files regardless of type 

Fixes #370
SimenB pushed a commit that referenced this issue Aug 31, 2020
@G-Rath @SimenB
fix(no-large-snapshots): run on all files regardless of type (#637)
332da31 
BREAKING CHANGE: `no-large-snapshots` runs on all files regardless of type 

Fixes #370
SimenB pushed a commit that referenced this issue Sep 4, 2020
@G-Rath @SimenB
fix(no-large-snapshots): run on all files regardless of type (#637)
b584dee 
BREAKING CHANGE: `no-large-snapshots` runs on all files regardless of type 

Fixes #370
@SimenB SimenB closed this as completed in 22113db Sep 4, 2020
github-actions bot pushed a commit that referenced this issue Sep 4, 2020
@semantic-release-bot
chore(release): 24.0.0 [skip ci]
1392cf3 
# [24.0.0](v23.20.0...v24.0.0) (2020-09-04)

### Bug Fixes

* **no-large-snapshots:** run on all files regardless of type ([#637](#637)) ([22113db](22113db)), closes [#370](#370)
* remove Jasmine globals ([#596](#596)) ([a0e2bc5](a0e2bc5))
* update to typescript-eslint@4 ([1755965](1755965)), closes [#590](#590)

### Code Refactoring

* **no-test-callback:** rename rule to `no-done-callback` ([#653](#653)) ([e15a8d1](e15a8d1))

### Features

* **no-done-callback:** support hooks ([#656](#656)) ([3e6cb44](3e6cb44)), closes [#649](#649) [#651](#651)
* add `no-conditional-expect` to the recommended ruleset ([40cd89d](40cd89d))
* add `no-deprecated-functions` to the recommended ruleset ([5b2af00](5b2af00))
* add `no-interpolation-in-snapshots` to the recommended ruleset ([3705dff](3705dff))
* add `valid-title` to recommended ruleset ([41f7873](41f7873))
* drop support for node 8 ([#570](#570)) ([6788e72](6788e72))
* set `no-jasmine-globals` to `error` in recommended ruleset ([7080952](7080952))
* **no-large-snapshots:** remove `whitelistedSnapshots` option ([8c1c0c9](8c1c0c9))

### BREAKING CHANGES

* **no-done-callback:** `no-done-callback` will now report hooks using callbacks as well, not just tests
* **no-test-callback:** rename `no-test-callback` to `no-done-callback`
* recommend `no-conditional-expect` rule
* recommend `no-interpolation-in-snapshots` rule
* recommend `no-deprecated-functions` rule
* recommend `valid-title` rule
* recommend erroring for `no-jasmine-globals` rule
* **no-large-snapshots:** `no-large-snapshots` runs on all files regardless of type
* Jasmine globals are no marked as such
* Node 10+ required
@github-actions
Copy link

github-actions bot commented Sep 4, 2020

🎉 This issue has been resolved in version 24.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@G-Rath G-Rath

Labels
enhancement released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(no-large-snapshots): run on files of any type graphan/eslint-plugin-jest
3 participants
@SimenB @G-Rath @graphan