feat: support allow option in lowercase-name rule
#419
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Merged
|
@SimenB I've got a few minor improvement PRs incoming, which'll probably have some merge conflicts on them. This is the main one that needs reviewing - If you review & approve, I'm happy to merge after resolving any conflicts that come up (i.e instead of having you re-review each PR as they're merged). |
G-Rath
force-pushed
the
lowercase-name-support-prefix-whitelist
branch
2 times, most recently
from
c0551f4
to
0da1d7a
Compare
jeysal
approved these changes
Sep 30, 2019
SimenB
reviewed
Sep 30, 2019
SimenB
approved these changes
Sep 30, 2019
G-Rath
force-pushed
the
lowercase-name-support-prefix-whitelist
branch
from
0da1d7a
to
625b8d2
Compare
G-Rath
force-pushed
the
lowercase-name-support-prefix-whitelist
branch
from
625b8d2
to
b03068e
Compare
|
🎉 This PR is included in version 22.19.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes things a bit nicer for writing tests for
supertest.When I finally get time to finish off my test prefix rule, it might be worth merging into that, but that'd require the whole rule to be merged in.