Improve types #420
Merged
Improve types #420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
improve-types
branch
2 times, most recently
from
9188e59
to
b8c03ee
Compare
|
I'm going to merge this as I think the remaining unresolved comment isn't worth blocking on: if it is a problem, it'll mean rethinking our coverage, and/or waiting for a bug fix on another package. It's pretty easy to address in post if we want :) Cheers for the reviews! |
|
🎉 This PR is included in version 22.21.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes most of our type casts, making things a bit nicer.
This will cause a merge conflict w/ #419