feat(lowercase-name): support ignoreTopLevelDescribe option
#611
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
allow-uppercase-in-toplevel-describe
branch
from
c362bbf
to
0b75c4d
Compare
SimenB
approved these changes
Jun 23, 2020
|
Really? I agree except for with things like classes & components, which I feel is pretty common; but then again it's definitely not the most obvious or pressing option 🤷 |
|
🎉 This PR is included in version 23.17.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Jun 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #247
closes #428
I think this should be the default in the next major, as it's a pretty common-case to have when testing classes.