refactor: inline collectReferences utility into scopeHasLocalReference
#1276
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
huh so apparently we didn't need the |
G-Rath
force-pushed
the
refactor-check
branch
from
a3f68d0
to
b1c1c35
Compare
SimenB
approved these changes
Nov 4, 2022
|
🎉 This PR is included in version 27.1.5 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow on to #1274 & #1275 - in theory this is faster but it has no noticeable impact on performance so I'm marking this as a refactor rather than
perf.The actual reason I'm doing it in the first place is because it makes the codebase a little smaller and we don't really need the two functions anymore.