feat: prefer importing jest globals for specific types #1568
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomquist
force-pushed
the
add-jest-global-types
branch
2 times, most recently
from
5b7aa20
to
38eb74a
Compare
G-Rath
requested changes
Apr 26, 2024
G-Rath
reviewed
Apr 26, 2024
tomquist
force-pushed
the
add-jest-global-types
branch
from
beb5655
to
2f342f5
Compare
Accessing the `jest` global in ESM must be done either through `import.meta.jest` or by importing it from `@jest/globals`. The latter is useful while migrating to ESM because the former is not accessible in non-ESM. This adds an option to specify the types of globals for which we want to enforce the import.
tomquist
force-pushed
the
add-jest-global-types
branch
from
2f342f5
to
cb9d9fd
Compare
G-Rath
reviewed
Apr 27, 2024
G-Rath
approved these changes
Apr 27, 2024
|
Thanks for the quick review! |
github-actions bot
pushed a commit
that referenced
this pull request
Apr 27, 2024
# [28.3.0](v28.2.0...v28.3.0) (2024-04-27) ### Features * prefer importing jest globals for specific types ([#1568](#1568)) ([c464ae3](c464ae3))
|
🎉 This PR is included in version 28.3.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Accessing the
jestglobal in ESM must be done either throughimport.meta.jestor by importing it from@jest/globals. The latter is useful while migrating to ESM because the former is not accessible in non-ESM.This adds an option to specify the types of globals for which we want to enforce the import.