ts-migration/valid-expect #387
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
approved these changes
Aug 12, 2019
| 'test("valid-expect", () => expect(Promise.reject(2)).resolves.not.toBeDefined());', | ||
| 'test("valid-expect", () => expect(Promise.reject(2)).rejects.not.toBeDefined());', | ||
| // 'test("valid-expect", () => expect(Promise.reject(2)).not.resolves.toBeDefined());', |
There was a problem hiding this comment.
I left there here commented out b/c the whole thing was a mess, and I didn't know what the & wasn't valid :)
Case & point, up until now we were testing the the exact opposite of the correct (not.resolve) was correct.
Feel free to remove them if you want, but I'll def be circling back, so they won't be there for ever :)
|
This turned out pretty clean, I love it! 😀 |
|
Just wait until we've got all the rules converted, and I do my second pass over everything ;) |
|
🎉 This PR is included in version 22.15.1 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
chore(valid-expect): convert to typescript
Closes #333