Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Better support valid each #460

Merged
merged 3 commits into from Oct 28, 2019
Merged

Better support valid each #460

merged 3 commits into from Oct 28, 2019

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented Oct 28, 2019

Fixes #458

@G-Rath
Copy link
Collaborator Author

G-Rath commented Oct 28, 2019

This'll likely be less than perfect, but too tired to be bothered trying to weed every last use-case out.

Much rather have them reported by users w/ IRL code to test against.
Either way, it's better than what we had before, which was no support :D

@G-Rath G-Rath merged commit 10e5087 into master Oct 28, 2019
@G-Rath G-Rath deleted the better-support-valid-each branch October 28, 2019 11:37
@github-actions
Copy link

🎉 This PR is included in version 23.0.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

valid-title: false positives when using it.each
1 participant
@G-Rath