Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecate rules #583

Merged
merged 3 commits into from May 16, 2020
Merged

Deprecate rules #583

merged 3 commits into from May 16, 2020

Conversation

G-Rath
Copy link
Collaborator

@G-Rath G-Rath commented May 16, 2020

Per discussion in #575

SimenB
SimenB approved these changes May 16, 2020
View reviewed changes
Copy link
Member

@SimenB SimenB left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@G-Rath
Copy link
Collaborator Author

G-Rath commented May 16, 2020 •
edited

Can I get a sanity check on the layout for squashing and merging?

Ideally we'd like a changelog entry for each deprecation, but I'm not sure if squashing this will give that - Semantic Pull Request is recommending a merge or rebase instead of a squash.

(I'm not too fussed, but just interested in a sense check for self-learning purposes 🙂)

@SimenB
Copy link
Member

SimenB commented May 16, 2020

Yeah, rebase merge is the way to go 👍

@G-Rath G-Rath merged commit 1360e9b into master May 16, 2020
@G-Rath G-Rath deleted the deprecate-rules branch May 16, 2020 08:50
@github-actions
Copy link

🎉 This PR is included in version 23.12.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@SimenB
Copy link
Member

SimenB commented May 16, 2020

might have been considered breaking, dunno... I have no idea how eslint handles deprecated rules. If it doesn't warn at all I guess it's fine, but then what's the point?

Meh 🤷

@G-Rath
Copy link
Collaborator Author

G-Rath commented May 16, 2020 •
edited

No it's not breaking - I can't remember the exact way it handles them, but I know it's at least not breaking enough for eslint & (I think, but can't find?) typescript-eslint to deprecate rules in minors :)

At the very least we've deprecated rules in minors in the past, so 🤷‍♀️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimenB SimenB SimenB approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@G-Rath @SimenB