Use suggestion instead of fix #586
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Actually, it doesn't simplify it as much as I thought :/ |
G-Rath
force-pushed
the
use-suggestion-instead-of-fix
branch
from
050be4c
to
526b608
Compare
|
Ah bugger - because @SimenB would you be ok with ignoring the coverage target for eslint v5? |
SimenB
approved these changes
May 17, 2020
| @@ -16,41 +17,132 @@ ruleTester.run('no-test-callback', rule, { | |||
| 'test("something", function() {})', | |||
| 'test("something", async function () {})', | |||
| 'test("something", someArg)', | |||
| 'test("something", (...args) => {args[0]();})', | |||
There was a problem hiding this comment.
we should error here as well, although we can't apply the fix.
Jest just provides the one argument, so it's just the fixer that doesn't work, with the rule active we should still warn about this case
G-Rath
force-pushed
the
use-suggestion-instead-of-fix
branch
3 times, most recently
from
8532f5d
to
31bcaab
Compare
G-Rath
commented
May 22, 2020
G-Rath
force-pushed
the
use-suggestion-instead-of-fix
branch
2 times, most recently
from
7e6a91b
to
5cd30c6
Compare
G-Rath
force-pushed
the
use-suggestion-instead-of-fix
branch
3 times, most recently
from
e295d24
to
ee19dee
Compare
SimenB
approved these changes
Jun 20, 2020
G-Rath
force-pushed
the
use-suggestion-instead-of-fix
branch
2 times, most recently
from
b459153
to
7c828d2
Compare
G-Rath
force-pushed
the
use-suggestion-instead-of-fix
branch
from
7c828d2
to
e9a3e58
Compare
|
馃帀 This PR is included in version 23.14.0 馃帀 The release is available on: Your semantic-release bot 馃摝馃殌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've done these as
fixs because they're safer, so feels like it's ok to do a patch in?Also I realised how to break
no-test-callbackby not checking that it's type is anIdentifier馃槀Are there any other rules we think should use an suggestion instead of autofixing? (or that don't have any fixes already that could suggest).
fixes #483
fixes #586