test: ensure cwd is restored after each test
#604
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Interesting - it's probably not that, but out of interest I'm guessing Jest provides that regardless of Node version? because it wasn't implemented until Node 12.... It's failing very inconsistently, so I think it's a race condition overall. |
|
It's conditional based on what's available in the running version of node, see jestjs/jest#9469 |
Good to know. |
|
🎉 This PR is included in version 23.14.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #591
I'm really curious to why this only failed on Node 8 & 10 - my guess is that
Module.createRequirebehaviour works slightly differently than the fallback methods, but haven't tested that in full.