Release v25 #905

SimenB · 2021-09-20T12:55:03Z

Just to keep track.

I believe for semantic-release to be happy we need to merge this (rather than squash or rebase), so I'll toggle the setting allowing it when we're ready to roll this.

Missing:

BREAKING CHANGE: Drop support for Node 10 and 15

# [25.0.0-next.1](v24.4.0...v25.0.0-next.1) (2021-09-13) ### Bug Fixes * stop testing on Node 10 and 15 ([#891](#891)) ([bcd8d11](bcd8d11)) ### BREAKING CHANGES * Drop support for Node 10 and 15

BREAKING CHANGE: Drop support for ESLint 5

# [25.0.0-next.2](v25.0.0-next.1...v25.0.0-next.2) (2021-09-13) ### Bug Fixes * stop testing ESLint 5 ([#893](#893)) ([47a0138](47a0138)) ### BREAKING CHANGES * Drop support for ESLint 5

BREAKING CHANGE: Removes rules `no-expect-resolves`, `no-truthy-falsy`, `no-try-expect`, and `prefer-inline-snapshots`

# [25.0.0-next.3](v25.0.0-next.2...v25.0.0-next.3) (2021-09-17) ### Features * remove deprecated rules ([#661](#661)) ([e8f16ec](e8f16ec)) ### BREAKING CHANGES * Removes rules `no-expect-resolves`, `no-truthy-falsy`, `no-try-expect`, and `prefer-inline-snapshots`

# [25.0.0-next.4](v25.0.0-next.3...v25.0.0-next.4) (2021-09-20) ### Bug Fixes * mark rules that suggest fixes with `hasSuggestion` for ESLint v8 ([#898](#898)) ([ec0a21b](ec0a21b)) * use correct property `hasSuggestions` rather than `hasSuggestion` ([#899](#899)) ([dfd2368](dfd2368))

G-Rath · 2021-09-22T20:03:43Z

@SimenB are you wanting to land #905 as a breaking change, or are you wanting to get it landed before the new major so that folks can get that fix without needing to do the major upgrade?

I'm fine with either, but if it's the latter then I think we should apply the parseJestVersion code + #897 (which really should be done together) first as tbh that is a bug fix.

SimenB · 2021-09-22T20:39:21Z

Current thinking is that #903 (which I assume you meant to link to) is a semver minor, so the plan is to merge this after #889 lands

G-Rath · 2021-09-22T20:42:04Z

Actually I meant to link to #889 🤦

SimenB · 2021-09-22T21:29:33Z

Ah. Plan is to land that as the last patch of 24 then move on with 25 🙂 Just missing the docs thing in #897, then I'll land all three (those two and this)

G-Rath · 2021-09-25T20:32:48Z

@SimenB I just remembered about #864 😅

That rule opens up the possibility of deprecating prefer-to-be-undefined & prefer-to-be-null (which the PR doesn't do because they're in our style config), so if you're happy with that we could land it now and remove those two rules in this major, replacing them with the new rule in our style config.

The PR is all good to go if you're happy with that :)

G-Rath · 2021-09-25T20:34:04Z

@SimenB have opened #910 which I think we should merge before the new major too.

G-Rath · 2021-09-25T20:42:45Z

@SimenB also random thought: should we rename lowercase-name to something like prefer-lowercase-title? I'm not too fussed, but it struck me as I was looking over some issues that it's sort of an odd duck vs our other rules (e.g. no-identical-title, valid-title).

G-Rath · 2021-09-25T23:28:35Z

Another naming thought: might make sense to rename valid-describe to valid-describe-callback, since that is actually what the rule is checking vs e.g. valid-title which applies to describes.

SimenB · 2021-09-29T07:49:51Z

@SimenB I just remembered about #864 😅

That rule opens up the possibility of deprecating prefer-to-be-undefined & prefer-to-be-null (which the PR doesn't do because they're in our style config), so if you're happy with that we could land it now and remove those two rules in this major, replacing them with the new rule in our style config.

The PR is all good to go if you're happy with that :)

Let's do it 👍

@SimenB also random thought: should we rename lowercase-name to something like prefer-lowercase-title? I'm not too fussed, but it struck me as I was looking over some issues that it's sort of an odd duck vs our other rules (e.g. no-identical-title, valid-title).

Seems reasonable to me 🙂

Another naming thought: might make sense to rename valid-describe to valid-describe-callback, since that is actually what the rule is checking vs e.g. valid-title which applies to describes.

Yeah, agreed

# [25.0.0-next.5](v25.0.0-next.4...v25.0.0-next.5) (2021-09-29) ### Bug Fixes * **no-deprecated-functions:** remove `process.cwd` from resolve paths ([#889](#889)) ([6940488](6940488)) * **no-identical-title:** always consider `.each` titles unique ([#910](#910)) ([a41a40e](a41a40e)) * **valid-expect-in-promise:** support `finally` ([#914](#914)) ([9c89855](9c89855)) * **valid-expect-in-promise:** support additional test functions ([#915](#915)) ([4798005](4798005)) ### Features * create `prefer-expect-resolves` rule ([#822](#822)) ([2556020](2556020)) * create `prefer-to-be` rule ([#864](#864)) ([3a64aea](3a64aea)) * **require-top-level-describe:** support enforcing max num of describes ([#912](#912)) ([14a2d13](14a2d13)) * **valid-title:** allow custom matcher messages ([#913](#913)) ([ffc9392](ffc9392))

# [25.0.0-next.6](v25.0.0-next.5...v25.0.0-next.6) (2021-10-10) ### Bug Fixes * **lowercase-name:** consider skip and only prefixes for ignores ([#923](#923)) ([8716c24](8716c24)) * **prefer-to-be:** don't consider RegExp literals as `toBe`-able ([#922](#922)) ([99b6d42](99b6d42)) ### Features * create `require-hook` rule ([#929](#929)) ([6204b31](6204b31)) * deprecate `prefer-to-be-null` rule ([4db9161](4db9161)) * deprecate `prefer-to-be-undefined` rule ([fa08f09](fa08f09)) * **valid-expect-in-promise:** re-implement rule ([#916](#916)) ([7a49c58](7a49c58))

BREAKING CHANGE: recommend `prefer-to-be` rule

BREAKING CHANGE: removed `prefer-to-be-null` rule

BREAKING CHANGE: removed `prefer-to-be-undefined` rule

BREAKING CHANGE: renamed `lowercase-name` to `prefer-lowercase-title`

BREAKING CHANGE: renamed `valid-describe` to `valid-describe-callback`

# [25.0.0-next.7](v25.0.0-next.6...v25.0.0-next.7) (2021-10-10) ### Features * add `prefer-to-be` to style ruleset ([2a3376f](2a3376f)) * **lowercase-name:** rename to `prefer-lowercase-title` ([b860084](b860084)) * **prefer-to-be-null:** remove rule ([809bcda](809bcda)) * **prefer-to-be-undefined:** remove rule ([3434d9b](3434d9b)) * **valid-describe:** rename to `valid-describe-callback` ([f3e9e9a](f3e9e9a)) ### BREAKING CHANGES * **valid-describe:** renamed `valid-describe` to `valid-describe-callback` * **lowercase-name:** renamed `lowercase-name` to `prefer-lowercase-title` * **prefer-to-be-undefined:** removed `prefer-to-be-undefined` rule * **prefer-to-be-null:** removed `prefer-to-be-null` rule * recommend `prefer-to-be` rule

SimenB · 2021-10-10T09:26:32Z

github-actions · 2021-10-10T09:32:57Z

🎉 This PR is included in version 25.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

SimenB and others added 14 commits September 13, 2021 11:51

fix: stop testing on Node 10 and 15 (#891)

bcd8d11

BREAKING CHANGE: Drop support for Node 10 and 15

chore(release): 25.0.0-next.1 [skip ci]

13c041a

# [25.0.0-next.1](v24.4.0...v25.0.0-next.1) (2021-09-13) ### Bug Fixes * stop testing on Node 10 and 15 ([#891](#891)) ([bcd8d11](bcd8d11)) ### BREAKING CHANGES * Drop support for Node 10 and 15

fix: stop testing ESLint 5 (#893)

47a0138

BREAKING CHANGE: Drop support for ESLint 5

chore(release): 25.0.0-next.2 [skip ci]

ef08fa6

# [25.0.0-next.2](v25.0.0-next.1...v25.0.0-next.2) (2021-09-13) ### Bug Fixes * stop testing ESLint 5 ([#893](#893)) ([47a0138](47a0138)) ### BREAKING CHANGES * Drop support for ESLint 5

chore: update dev dependencies (#894)

efe56c1

Merge branch 'main' into next

b0888c7

feat: remove deprecated rules (#661)

e8f16ec

BREAKING CHANGE: Removes rules `no-expect-resolves`, `no-truthy-falsy`, `no-try-expect`, and `prefer-inline-snapshots`

chore: update yarn to v3 (#900)

6aa7eea

Merge branch 'main' into next

74cd2ae

Merge branch 'main' into next

2a0b43b

Merge branch 'main' into next

30e13fe

Merge branch 'main' into next

5c0504c

SimenB and others added 7 commits September 29, 2021 09:54

Merge branch 'main' into next

0fd748f

Merge branch 'main' into next

6708bb8

feat: add prefer-to-be to style ruleset

2a3376f

BREAKING CHANGE: recommend `prefer-to-be` rule

feat(prefer-to-be-null): remove rule

809bcda

BREAKING CHANGE: removed `prefer-to-be-null` rule

feat(prefer-to-be-undefined): remove rule

3434d9b

BREAKING CHANGE: removed `prefer-to-be-undefined` rule

G-Rath and others added 3 commits October 10, 2021 11:22

feat(lowercase-name): rename to prefer-lowercase-title

b860084

BREAKING CHANGE: renamed `lowercase-name` to `prefer-lowercase-title`

feat(valid-describe): rename to valid-describe-callback

f3e9e9a

BREAKING CHANGE: renamed `valid-describe` to `valid-describe-callback`

SimenB marked this pull request as ready for review October 10, 2021 09:26

SimenB merged commit 2dce752 into main Oct 10, 2021

SimenB deleted the next branch October 10, 2021 09:26

github-actions bot added the released label Oct 10, 2021

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Release v25 #905

Release v25 #905

SimenB commented Sep 20, 2021 •

edited

G-Rath commented Sep 22, 2021

SimenB commented Sep 22, 2021

G-Rath commented Sep 22, 2021

SimenB commented Sep 22, 2021 •

edited

G-Rath commented Sep 25, 2021

G-Rath commented Sep 25, 2021

G-Rath commented Sep 25, 2021

G-Rath commented Sep 25, 2021

SimenB commented Sep 29, 2021

SimenB commented Oct 10, 2021

github-actions bot commented Oct 10, 2021

Release v25 #905

Release v25 #905

Conversation

SimenB commented Sep 20, 2021 • edited

G-Rath commented Sep 22, 2021

SimenB commented Sep 22, 2021

G-Rath commented Sep 22, 2021

SimenB commented Sep 22, 2021 • edited

G-Rath commented Sep 25, 2021

G-Rath commented Sep 25, 2021

G-Rath commented Sep 25, 2021

G-Rath commented Sep 25, 2021

SimenB commented Sep 29, 2021

SimenB commented Oct 10, 2021

github-actions bot commented Oct 10, 2021

SimenB commented Sep 20, 2021 •

edited

SimenB commented Sep 22, 2021 •

edited