Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(expect-expect): don't error on it.todo & test.todo calls #954

Merged
merged 1 commit into from Oct 15, 2021
Merged

fix(expect-expect): don't error on it.todo & test.todo calls #954

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/rules/__tests__/expect-expect.test.ts
View file
Open in desktop
Expand Up @@ -15,6 +15,8 @@ const ruleTester = new TSESLint.RuleTester({

ruleTester.run('expect-expect', rule, {
valid: [
'it.todo("will test something eventually")',
'test.todo("will test something eventually")',
"['x']();",
'it("should pass", () => expect(true).toBeDefined())',
'test("should pass", () => expect(true).toBeDefined())',
Expand Down
8 changes: 8 additions & 0 deletions src/rules/expect-expect.ts
View file
Open in desktop
Expand Up @@ -11,6 +11,7 @@ import {
createRule,
getNodeName,
getTestCallExpressionsFromDeclaredVariables,
isSupportedAccessor,
isTestCaseCall,
} from './utils';

Expand Down Expand Up @@ -116,6 +117,13 @@ export default createRule<
isTestCaseCall(node) ||
additionalTestBlockFunctions.includes(name)
) {
if (
node.callee.type === AST_NODE_TYPES.MemberExpression &&
isSupportedAccessor(node.callee.property, 'todo')
) {
return;
}

unchecked.push(node);
} else if (matchesAssertFunctionName(name, assertFunctionNames)) {
// Return early in case of nested `it` statements.
Expand Down