Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feat] Remove support for old 'output' setting #101

Merged
merged 1 commit into from Aug 26, 2019
Merged

[feat] Remove support for old 'output' setting #101

merged 1 commit into from Aug 26, 2019

Conversation

alde
Copy link
Contributor

@alde alde commented Aug 26, 2019

Breaking change

Remove the output setting, and change the default of outputDirectory
from null to process.cwd().

This will cause the defaults for outputDirectory and outputName to
be joined together to the same as the old output value, with the added
benefit of them being overrideable separately.

Fixes #100

Breaking change

Remove the `output` setting, and change the default of `outputDirectory'
from `null` to `process.cwd()`.

This will cause the defaults for `outputDirectory` and `outputName` to
be joined together to the same as the old `output` value, with the added
benefit of them being overrideable separately.

Fixes #100
@palmerj3 palmerj3 merged commit 43a8de6 into jest-community:master Aug 26, 2019
@palmerj3
Copy link
Collaborator

Thank you!

@literalpie
Copy link

An example that people may find useful:

We have a project that did have a configuration of: "output": "./test-results/xml-reports/unit-results.xml",
With this change, the configuration is now:

{
    "outputDirectory": "./test-results/xml-reports",
    "outputName": "unit-results.xml",
    ...
}

NoxHarmonium added a commit to NoxHarmonium/node1016-jenkins-library that referenced this pull request Nov 25, 2019
Version v8.0.0 of jest-junit removed the `JEST_JUNIT_OUTPUT` environment variable in favour of `JEST_JUNIT_OUTPUT_DIR` and `JEST_JUNIT_OUTPUT_NAME`.

I will leave the old environment variable for backwards compatibility as it will just be ignored in newer versions.

jest-community/jest-junit#101
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to specify only 'outputName'
3 participants