Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: refresh lockfiles to get rid of security alert #85

Merged
merged 3 commits into from Jan 27, 2020
Merged

Conversation

SimenB
Copy link
Member

@SimenB SimenB commented Jan 27, 2020

It just complains about set-value which we get via chokidar, sane and micromatch - all development dependencies.

I just deleted the lockfiles and ran yarn again. Will merge if green

@ljharb
Copy link
Collaborator

ljharb commented Jan 27, 2020

seems simpler to get rid of the lockfiles for the examples.

@SimenB
Copy link
Member Author

SimenB commented Jan 27, 2020

Yeah, let's

@SimenB
Copy link
Member Author

SimenB commented Jan 27, 2020

@babel/preset-env depends on levenary, which is node 8+...

babel/babel#10924 (comment)

@SimenB
Copy link
Member Author

SimenB commented Jan 27, 2020

I can force a lower version of preset-env to unblock. It's just a dev tool, so doesn't affect consumers

@ljharb
Copy link
Collaborator

ljharb commented Jan 27, 2020

That seems like a breaking change for preset-env; could you file an issue?

@SimenB
Copy link
Member Author

SimenB commented Jan 27, 2020

Yeah, I added a comment to the PR which added it to babel

@SimenB
Copy link
Member Author

SimenB commented Jan 27, 2020

Upstream fix: tanhauhau/levenary#3

If merged and released we can upgrade again.

@SimenB SimenB merged commit a239b61 into master Jan 27, 2020
@SimenB SimenB deleted the refresh-locks branch January 27, 2020 16:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants