feat: Support ESLint 7.x #92
Conversation
|
@MichaelDeBoey please rebase and mark as "ready for review" once tests are passing :-) |
|
@ljharb This one's waiting for |
|
aha, thanks, that’s on me. Hopefully this week. |
|
CI seems unhappy for the same reason as in #78. We probably want to leave the eslint config alone |
|
@ljharb Any idea how to resolve ESLint errors? |
|
I see a few errors; one of them is because yarn incorrectly fails installs when engines mismatch (they’re advisory only); if there’s a way to yarn install without that check, that’s the fix there (or switching to the standard package manager, of course) The linting error suggests that perhaps eslint isn’t properly updated in the lockfile? I don’t use lockfiles on packages so I’m not sure, but my guess is if you deleted and recreated the lockfile it’d pass. |
|
Seems like the eslint 4 tests won't work with the camelcase rule; i wonder if we could override those, with something like |
|
|
|
Looks like the |
|
k i think the last issue is that for eslint 4, we have to have a way to override the config for the |
|
@ljharb Any idea how I could do this override? |
|
You could pass |
|
@ljharb I tried just adding it, but that didn't work. |
|
@ljharb Any idea how I could resolve the failures exactly? |
ljharb
force-pushed
the
eslint-7
branch
2 times, most recently
from
b4a5376
to
16cab9b
Compare
|
First, I updated the test matrix; the peer deps support jest 21-26 and eslint 4-7, and the implied node version somewhere between 4-14, depending on which combo you're using. As is, tests are failing on jest 21, 22, and 23 on master, as well as on eslint 4 with all versions of jest: https://travis-ci.org/github/jest-community/jest-runner-eslint/builds/704554241 Next, I tried to fix the eslint 4 failures, which were just about the camelcase rule's extra option. I did that by, in travis, when eslint was v4, installing eslint-config-airbnb-base@13. That left these failures: https://travis-ci.org/github/jest-community/jest-runner-eslint/builds/704558140 which are, "still failing on jest < 24" but passing on eslint 4. Failures are: on jest 21, "TypeError: glob pattern string required"; on jest 22, "SecurityError: localStorage is not available for opaque origins" (fixed with advice from jsdom/jsdom#2304); and on jest 22 and 23, related to babel 6 vs 7 : https://travis-ci.org/github/jest-community/jest-runner-eslint/builds/704562583 The node 4 failure is because travis' default yarn version doesn't work on node 4, yay. In other words, it seems like unless we want to a) ditch yarn (which i strongly recommend anyways, for a variety of reasons), b) do some babel 6/7 hijinx in travis.yml, c) fix whatever actual test failures pop up, if any (i actually suspect everything works fine! it's just that it hasn't been properly tested for a long time, so who knows) - then we'd want to just drop whatever's failing. It also looks like "projects" isn't supported in jest 21 at all inside a config file. So, I added a commit that drops support for eslint < 6 and jest < 25 (ie, so we keep supporting the last 2 versions of both eslint and jest). Moving forward, we'll be able to ensure we test every node and eslint and jest version combo that's supported, and prevent this kind of situation from happening again. |
|
Supporting last 2 majors seems reasonable to me! 👍 |
|
CI failed because of removing |
|
Huh - what's installing semver@7 when we target node 8? |
|
Investigating as we speak 🙂 |
|
@SimenB It seems to be triggered whenever |
|
(note that |
|
@ljharb |
|
Thanks for merging @ljharb! 👊 |
|
@SimenB Any idea when this will be released? 🤔 |
|
I'd like to bump all other dependencies as well first (at least the ones that still support node 8) |
|
@SimenB On it boss! 😉 |
|
@MichaelDeBoey I've opened up #98 |
ESLint v7.0.0 is released 🎉
(dev)Dependencies should be compatible with ESLint 7 too before we can merge this one:
eslint-config-airbnb-baseeslint-plugin-importeslint-plugin-jesteslint-plugin-prettierCloses #78
Closes #91