feat!: ignore typingsFile
option and deprecate @type
pragma
#40
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@SimenB Another alternative which would unblock jestjs/jest#12198
This change makes the runner work just like it was in
v1.1.0
. ThetypingsFile
option always receives a path which exist in the file system and this silences thetsd
error: "The type definition [file] does not exist."This is the same trick which was documented as a workaround (so documentation can be skipped).
This change does not influence
tsd
's behaviour related with testing type definitions. All type checking works as before. And jestjs/jest#12199 would be unnecessary.Not sure I like this solution. Just another workaround. Might be worth to fork
tsd
, remove all extra checks it does and to use that fork. Simply a library which does one task – tests types.I have a draft already. Just wanted to check if it is worth the efforts?