Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add test name typeahead #1

Merged
merged 3 commits into from
May 29, 2018
Merged

feat: Add test name typeahead #1

merged 3 commits into from
May 29, 2018

Conversation

rogeliog
Copy link
Member

@rogeliog rogeliog requested a review from SimenB May 29, 2018 16:50
@rogeliog
Copy link
Member Author

rogeliog commented May 29, 2018

@rickhanlonii @SimenB, moving the typeahead naming conversation to here. I agree that standardizing on suite(jest-watch-typeahead/suite) would be really interesting, but I also like the how explicit jest-watch-typeahead/filename and jest-watch-typeahead/testname are.

I'm fine with any of the proposed options 🙃

@rickhanlonii
Copy link

+1, i like that "file name" and `"test name" match the prompt text as well

Copy link

@rickhanlonii rickhanlonii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rogeliog rogeliog merged commit 61b3078 into master May 29, 2018
@rogeliog rogeliog deleted the both-typeaheads branch May 29, 2018 17:13
@rogeliog rogeliog mentioned this pull request May 29, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants