Setup Travis and add tests #12
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SimenB
approved these changes
Jul 3, 2018
| @@ -0,0 +1,36 @@ | |||
| import { JestHook } from 'jest-watcher'; | |||
There was a problem hiding this comment.
what do you think about exporting this from jest-watcher. Eslint has great success by exporting helpers making it a breeze to test - watch plugins (and runners) might benefit from the same approach in the long run?
There was a problem hiding this comment.
I agree!!
I feel that it is a bit too early to move it... I'll work on making this plugin configurable(key, prompt, search-strategy, etc) and that should help me understand if this was the right abstraction for the tester.
| // $FlowFixMe | ||
| export const getTerminalWidth = (): number => process.stdout.columns; | ||
| export const getTerminalWidth = ( | ||
| pipe: stream$Writable | tty$WriteStream = process.stdout, |
There was a problem hiding this comment.
Nop, not a bug fix... It was failing in CI because columns is 0. I changed so that it can use the pipe that was passed as an argument, which means that now we can mock the number of columns.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR sets up Travis and add tests for each plugin. This should help a lot once this plugins become more complex