Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

New directory structure #14

Merged
merged 1 commit into from
Jul 6, 2018
Merged

New directory structure #14

merged 1 commit into from
Jul 6, 2018

Conversation

rogeliog
Copy link
Member

@rogeliog rogeliog commented Jul 6, 2018

The directory structure is starting to get messy. This PR updates the directory structure.

src
├── file_name_plugin
│   ├── __tests__
│   │   ├── __snapshots__
│   │   │   └── plugin.test.js.snap
│   │   └── plugin.test.js
│   ├── plugin.js
│   └── prompt.js
├── test_name_plugin
│   ├── __tests__
│   │   ├── __snapshots__
│   │   │   └── plugin.test.js.snap
│   │   └── plugin.test.js
│   ├── plugin.js
│   └── prompt.js
├── lib
│   ├── __tests__
│   │   └── utils.test.js
│   ├── pattern_mode_helpers.js
│   ├── scroll.js
│   └── utils.js
├── test_utils
│   └── pluginTester.js
└── types
    └── Config.js

@rogeliog rogeliog requested review from SimenB and thymikee July 6, 2018 01:15
SimenB
SimenB reviewed Jul 6, 2018
View reviewed changes
package.json
"scripts": {
"test": "jest",
"lint": "eslint .",
"watch": "babel src -w --ignore **/*.test.js,integration -d build",
"build": "babel src --ignore **/*.test.js,integration -d build",
"prepublish": "yarn build",
"format": "prettier --single-quote --trailing-comma all --write \"!(build)/**/*.js\""
"format":
"prettier --single-quote --trailing-comma all --write \"!(build)/**/*.js\""
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

updating prettier to 1.13 will stop if from formatting package.json differently from yarn/npm

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome!

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#17

@rogeliog rogeliog merged commit 62fc126 into master Jul 6, 2018
@rogeliog rogeliog deleted the dir-structure branch July 6, 2018 05:51
@dependencies dependencies bot mentioned this pull request Jul 15, 2018
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SimenB SimenB SimenB approved these changes

@thymikee thymikee Awaiting requested review from thymikee

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@rogeliog @SimenB