Make matching case insensitive #18
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogeliog
force-pushed
the
case-insensitive
branch
from
27105bb
to
ff50088
Compare
SimenB
reviewed
Jul 6, 2018
src/file_name_plugin/prompt.js
Outdated
| context: { config }, | ||
| })), | ||
| testPaths | ||
| .filter(testPath => (regex ? testPath.match(regex) : false)) |
There was a problem hiding this comment.
can use .test as you only care about true/false, not the match
There was a problem hiding this comment.
also, regex will always be truthy as this is inside if (regex)
There was a problem hiding this comment.
Yeah, but Flow doesn't know that https://flow.org/en/docs/lang/refinements/#toc-refinement-invalidations
Although I think I can rewrite it a bit to avoid this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #10
testNamePatternis case insensitive, so the typeahead should respect that.This was a regression introduced when I extracted the typeahead from Jest core.