Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use fullName(to show ancestor titles) for test name pattern plugin #26

Merged
merged 2 commits into from
Mar 14, 2019

Conversation

rogeliog
Copy link
Member

@rogeliog rogeliog commented Mar 13, 2019

Fixes: #24

This should allow the test name pattern plugin to display "describe" blocks.

Screen Shot 2019-03-13 at 4 46 15 PM

I think we don't need to check for fullName and title because watch plugins were introduced in Jest@23 and fullName was added in Jest@21

  • Should we decorate the output to better format each of the nested describe block(by using ancestorTitles) instead of a sentence? Or should we keep it as a sentence-ish? @SimenB

@SimenB
Copy link
Member

SimenB commented Mar 14, 2019

doing ancestorTitles.join(' > ') or something might make sense?

@rogeliog
Copy link
Member Author

Yeah I was also thinking of something like that, but it gets a bit tricky at the time of highlighting the matching text.

For example: If the pattern matches stuff that expands between describe blocks then we would need to do some extra work to highlight it correctly.

I'll give it a try, because I feel that the experience would be better with the > or

@rogeliog rogeliog changed the title Use fullName for test name pattern plugin Use fullName(ancestor titles) for test name pattern plugin Mar 14, 2019
@rogeliog rogeliog changed the title Use fullName(ancestor titles) for test name pattern plugin Use fullName(to show ancestor titles) for test name pattern plugin Mar 14, 2019
@rogeliog rogeliog merged commit b981b69 into master Mar 14, 2019
@SimenB SimenB deleted the fullname-testname-plugin branch May 10, 2021 19:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants