Get better truncation for testname typeahead by truncating the start and not the end #28
+90
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rogeliog
changed the title
thymikee
approved these changes
Mar 16, 2019
SimenB
reviewed
Mar 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a better truncation strategy for the test name typeahead. Now that we are showing the describe blocks the text can be really long
We should truncate the start of the test name instead of the end, given that the end of the test name is the "it/test" description, which tends to be more relevant and specific.
This is similar to how the filename plugin works, where it truncates the first directories, but not the filename.
Before
After